-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 0.3 alpha #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the following to REQUIRED: pandas, torch, torchvision, dask - bump version of crowsetta in REQUIRED to >=2.1.0
with keras.utils.Sequence class for Vak datasets
after changing vak.dataset.spect to vak.dataset.dataframe
so it adds a 'split' column to a DataFrame, instead of splitting a Dataset into subsets and then returning each subset as a separate Dataset.
- instead of having 'train_vds_path', 'val_vds_path', etc. - the 'split' column in the csv tells vak what splits there are and which samples belong to them
to emphasize this is a higher-level function that makes a dataset from **either** audio or spectrogram files
because they're not file input-output functions, so they don't belong in .io
make comma_separated_list converter just return the input value if it is already a list, or convert to list if it is a str, else raise a TypeError instead of crashing by trying to convert a list to a list
because no other functions actually use this attribute. User can just look at the path they specified as "root_results_dir" to figure out where the results are.
e.g. if there are no args passed to the loss function when instantiating it, just map the 'loss' key to an empty dictionary which will the get passed as the kwargs
from 'results' command, because 'config' command doesn't exist anymore
with iter_ helper function, that was in vak/models/util.py
This was referenced Feb 17, 2020
Closed
yardencsGitHub
pushed a commit
to yardencsGitHub/vak
that referenced
this pull request
Aug 17, 2020
version 0.3 alpha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consists of a giant "feature branch: the rough draft for version 0.3.
Since @yardencsGitHub and I are the only ones really interacting with the code base right now, I am merging this 200-something commit "feature" even though that is not really best practice for OS development. I think the structure of the codebase is actually now clean enough that future feature branches can be more targeted.
This way we can get to an alpha version that we and others can actually use and test, and move forward with other things that depend on that.
Major changes:
"doing things with spectrograms / audio that don't fit neatly into what people do
for computer vision tasks"
for saving and loading
disk space with things that are already in other files
from integer outputs of class predictions from network to the labels that the user assigns those
classes in the annotation
.vak
andtreat it like a "project"