Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vocdoni-node - ethless #42

Merged
merged 12 commits into from
Apr 4, 2022
Merged

Update Vocdoni-node - ethless #42

merged 12 commits into from
Apr 4, 2022

Conversation

NateWilliams2
Copy link
Contributor

This PR has three main changes:

  • use the new vocdoni-node signing methods
  • check & use account nonces for vochain transactions
  • collect tokens from faucet when creating a new account

@NateWilliams2 NateWilliams2 changed the title [WIP] Update Vocdoni-node - signing methods & faucet tx Update Vocdoni-node - signing methods & faucet tx Mar 25, 2022
@NateWilliams2 NateWilliams2 changed the title Update Vocdoni-node - signing methods & faucet tx Update Vocdoni-node - ethless Mar 25, 2022
@NateWilliams2
Copy link
Contributor Author

@jordipainan the CI is failing because there's a race on the vocone methods for SetTreasurer, MintTokens, SetTxCost, and setBulkTxCost, when these methods run app.State.Save() to save the changes to the state. This races with the main vochain goroutine.

I would say we can get around this by sending the transactions to do these things to the vocone API in testing, but I don't think we have a way to set the treasurer public key in that case. Do you know of a solution?

vocclient/vocclient.go Outdated Show resolved Hide resolved
vocclient/vocclient.go Outdated Show resolved Hide resolved
vocclient/vocclient.go Outdated Show resolved Hide resolved
test/testapi/api_test.go Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2077957497

  • 58 of 159 (36.48%) changed or added relevant lines in 6 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.1%) to 54.987%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/testcommon/apis.go 5 7 71.43%
test/testcommon/services.go 11 17 64.71%
cmd/vaasapi/vaasapi.go 0 8 0.0%
urlapi/entity.go 20 39 51.28%
vocclient/vocclient.go 19 85 22.35%
Files with Coverage Reduction New Missed Lines %
urlapi/public.go 2 56.36%
vocclient/vocclient.go 2 44.37%
Totals Coverage Status
Change from base Build 1983255489: -1.1%
Covered Lines: 1979
Relevant Lines: 3599

💛 - Coveralls

@jordipainan
Copy link
Member

sorry nate I missed this, but already commented on sync meeting, the locks are merged to the master branch :)

@jordipainan
Copy link
Member

PR LGTM ! We can go ahead ^^

@NateWilliams2 NateWilliams2 merged commit 93aa0b0 into master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants