-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vocdoni-node - ethless #42
Conversation
c084bc0
to
4565e84
Compare
90dd2ad
to
253a1f1
Compare
253a1f1
to
6022289
Compare
@jordipainan the CI is failing because there's a race on the vocone methods for SetTreasurer, MintTokens, SetTxCost, and setBulkTxCost, when these methods run I would say we can get around this by sending the transactions to do these things to the vocone API in testing, but I don't think we have a way to set the treasurer public key in that case. Do you know of a solution? |
Pull Request Test Coverage Report for Build 2077957497
💛 - Coveralls |
sorry nate I missed this, but already commented on sync meeting, the locks are merged to the master branch :) |
PR LGTM ! We can go ahead ^^ |
This PR has three main changes: