Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock to vocone blocks #532

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add lock to vocone blocks #532

merged 2 commits into from
Mar 31, 2022

Conversation

NateWilliams2
Copy link
Contributor

as suggested in vocdoni/vaas-api#42 (comment)
adds a lock to vocone block creation so helpers like mintTokens can be used without race conditions

jordipainan
jordipainan reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@jordipainan jordipainan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@G10h4ck
Copy link
Contributor

G10h4ck commented Mar 30, 2022 •
edited
Loading

looks good to me too, the CI seems to fail for an apparently unrelated thing

mvdan
mvdan approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. I'd just document what the lock actually protects - I assume it's the app field, but best not to guess.

@jordipainan jordipainan merged commit 80178ee into master Mar 31, 2022
@jordipainan jordipainan deleted the vocone-mtx branch March 31, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordipainan jordipainan jordipainan left review comments

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NateWilliams2 @G10h4ck @mvdan @jordipainan