f/optimistic provide

[altergui]

fix #989

[p4u]

fix the check please @altergui

[dennis-tra]

Great that you're taking the time to check this out!

I'm curious how your experience is. Quick question, are you using the IPFS DHT, another bigger DHT network, or a separate own one?

[p4u]

Great that you're taking the time to check this out!

I'm curious how your experience is. Quick question, are you using the IPFS DHT, another bigger DHT network, or a separate own one?

We are using IPFS DHT.

[p4u]

We are not logging any metric regarding the latency on the DHT node discovery.

Before merging this experimental feature, it would be great to add some ipfs-connect metrics to Prometheus @altergui

Feel free to comment and to discard this idea.

[dennis-tra]

When you get around adding metrics from before and after this change it would be great if you shared them with us. We would be interested in your experience with that feature 👍

[altergui]

sorry for taking so long, finally merged the stats in #1090 today
we'll collect current data (without optimistic provide) for a week, then merge this PR to enable optimistic provide, and report any differences

[dennis-tra]

Great, thanks for the ping! Looking forward to the results 👍

[coveralls]

Pull Request Test Coverage Report for Build 6482647686

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• 4 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.007%) to 57.942%

---

Files with Coverage Reduction	New Missed Lines	%
vochain/transaction/admin_tx.go	2	50.0%
vochain/transaction/transaction.go	2	41.65%

Totals
Change from base Build 6482114561:	-0.007%
Covered Lines:	12917
Relevant Lines:	22293

---

💛 - Coveralls

[dennis-tra]

From your linked PR #1090 I saw that you added a new metric with the help text: "The time it takes FindPeers to discover peers".

Just to clarify: Instead of improving the GET performance in the DHT, Optimistic Provide is designed to accelerate the PUT performance so that delay-sensitive applications can benefit from faster content publication.

[dennis-tra]

Hey everyone, just wanted to briefly follow up here and ask about the status

[p4u]

Now we have some metrics to compare.

We gonna merge this into the development network first, then on stage and finally production.