util: prevent PublicIP from taking tens of seconds #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-external-ip's default timeout is 30s, which is too long. Use 3s, which seems far more reasonable, and document it. It's not entirely clear why it's timing out; it seems like one of the providers is currently being slow or just not responding at all. It doesn't really matter; one of the providers not responding shouldn't hang our software for half a minute. Before this change, the ipfssync and ipfssync/subpub packages took between 30s and 60s to run their tests, presumably since they obtain the public IP more than once. With this change, the packages now take 3-6s to test, predictably. Closes vocdoni#434.
|
I think keeping the 1m test timeout per package is useful, precisely because it will help us keep our tests reasonably fast and catch long timeouts or sleeps like this one :) |
|
looks great 👍 |
NateWilliams2
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Closes #434.