Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashTracking: false -- still scrolls to top? #20

Closed
abacaj opened this issue Jun 11, 2014 · 8 comments
Closed

hashTracking: false -- still scrolls to top? #20

abacaj opened this issue Jun 11, 2014 · 8 comments
Labels

Comments

@abacaj
Copy link

abacaj commented Jun 11, 2014

I have disabled the hashTracking in the settings but it still scrolls on click. The modal div is as such:
<div class="remodal" data-remodal-id="modal">

and the link is:
<a data-remodal-target="modal" href="">Modal</a>

Any idea why it is still scrolling?

@vodkabears
Copy link
Owner

@abacaj1 It shouldn't do that. I've tested - no problems. Are you using the last version? And how have you disabled hashTracking? Try this: <div class="remodal" data-remodal-id="modal" data-remodal-options='{ "hashTracking": false }'>

@abacaj
Copy link
Author

abacaj commented Jun 11, 2014

Thanks for the swift reply. I changed it from the lines
var pluginName = "remodal", defaults = { hashTracking: false };

Yes it is the latest pull from git.

The modal pops up and then scrolls to the top of the page. Is there any way to prevent this from modals that have links at the bottom of the page?

@vodkabears
Copy link
Owner

@abacaj1 this is a strange situation, because i've fixed it in the version 0.1.3 and now i can't reproduce your problem. Do you have this problem in all browsers?

@abacaj
Copy link
Author

abacaj commented Jun 11, 2014

Yes, it is occurring in all browsers that I have tried including chrome and safari.

I will upload a short screencapture of this and upload it for you.

@vodkabears
Copy link
Owner

@abacaj1 ok, i'm waiting.

@abacaj
Copy link
Author

abacaj commented Jun 11, 2014

I narrowed it down to one line of CSS.

html,body,{height:100%;}

Is causing the modal to scroll up, when removed the modal does not scroll up anymore.

Is there any way around this as my page requires the layout to be 100% height.

@vodkabears
Copy link
Owner

@abacaj1 yep, that's a problem. Try to set html,body {min-height:100%;} instead of the height property.

@abacaj
Copy link
Author

abacaj commented Jun 12, 2014

Thanks for the help, this resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants