Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening of Modal Scrolling to Top of Page #21

Closed
nrly opened this issue Jun 23, 2014 · 3 comments
Closed

Opening of Modal Scrolling to Top of Page #21

nrly opened this issue Jun 23, 2014 · 3 comments

Comments

@nrly
Copy link

nrly commented Jun 23, 2014

Hey,

First up thanks for your great modal script.

I'm having the same issue described here #20.

However using min-height doesn't work in terms of keeping my #header div 100%. Currently set up as html, body {height: 100%;} and #header {min-height:100%;}. If I change html,body to min-height it doesn't fill the screen however the modal works correctly any doesn't scroll to the top of the page.

Is there any fix for this without having to remove height:100% ??

Thanks in advance!

@vodkabears
Copy link
Owner

@nrly in the remodal's CSS file remove overflow:hidden of the remodal_lock class or write in your styles: html, body { overflow: auto !important }. This solution will save scrollbar, but fix scrolling of the viewport.

@nrly
Copy link
Author

nrly commented Jun 24, 2014

Awesome! Thanks so much the quick reply this seems to have fixed it perfectly.

@nrly nrly closed this as completed Jun 24, 2014
@vodkabears vodkabears added bug and removed bug labels Jul 19, 2014
@paulcredmond
Copy link

Hi, I have the same issue and have implemented the fix as suggested above, while this does stop the page from jumping up the top, it does cause other issues, most notably, the background content is scrollable and depending on how the keyboard opens and closes, some of the background is revealed.

keyboard_off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants