Adding option to specify poster image type #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What CORS issues did you have? Poster could be found or no? |
|
The poster couldn't be found, I've added a screenshot. I think I have control over CORS policies with Amazon S3, so I could probably fix it but people using other CDNs may not have the same flexibility.
|
|
Ok, i understand, thank you. I had not thought about CORS. I will merge it, but, i think, i know one else solution without ajax. |
vodkabears
added a commit
that referenced
this pull request
Aug 10, 2014
Adding option to specify poster image type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Vide with a CDN host, I was having CORS issues when using $.get() to find the poster's image type.
I've added a new configuration setting,
posterTypeto allow developers to manually specify the image type: "png", "jpg", or "gif". The default is "detect", which preserves the existing logic.