Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xbox Games With Gold #160

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Xbox Games With Gold #160

merged 3 commits into from
Nov 6, 2023

Conversation

OJ7
Copy link
Contributor

@OJ7 OJ7 commented Jun 26, 2023

Working implementation for Xbox GWG (resolves #19).

Tested in various different states:

  • first time login (OTP requested)
  • login after sign out (OTP not always requested)
  • currently logged in

This seemed to run pretty quickly and reliably for me.

I mostly followed the code in gog.js and epic-games.js, but did some basic refactoring to group up code by functions to make it a little easier to follow.

@OJ7
Copy link
Contributor Author

OJ7 commented Jul 16, 2023

@vogler let me know what you need to get this merged. I tested this out twice this month and it worked flawlessly. I also pushed some fixes up for #165 and that seemed to work well too. I'll need to do a rebase once of these are in to fix conflicts in the other one.

@OJ7
Copy link
Contributor Author

OJ7 commented Jul 17, 2023

Welp, looks like this will only be useful for another month... Xbox Games with Gold is going away after 18 years of running. 😞

@OJ7 OJ7 closed this Jul 31, 2023
@vogler vogler reopened this Aug 27, 2023
@vogler
Copy link
Owner

vogler commented Aug 27, 2023

Thanks a lot! Sorry, this somehow got lost. I'll merge and keep xbox.js around - maybe it'll be useful for something later.

@vogler vogler merged commit 11db31e into vogler:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Store] Xbox Live Gold monthly free games
2 participants