Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playstation Plus Monthly Games #165

Closed
wants to merge 8 commits into from
Closed

Conversation

OJ7
Copy link
Contributor

@OJ7 OJ7 commented Jul 1, 2023

Working implementation for PlayStation Plus monthly games (resolves #141).

I'm having issues with being (possibly IP) blocked from logging in due to repeated login attempts and captcha being aggressive (adding dices to match a sum, ten times in a row, and still failing every time), but this was previously working for me when I was able to login and This has been working well for me this month and I think I got confirmation from @benwaco here as well.

@OJ7 OJ7 mentioned this pull request Jul 16, 2023
@neomanyouth
Copy link

Is this going to be pulled in soon? Would make this already awesome app complete from my perspective.

@4n4n4s
Copy link
Contributor

4n4n4s commented Aug 25, 2023

@OJ7 would be nice if based on subscription type Essential/Extra/Premium we could also add the other free games from the catalogs. Some of them always get removed from the catalogs so it would be great if we could also secure them in our pile of shame list of games.

ps-premium

@OJ7
Copy link
Contributor Author

OJ7 commented Aug 26, 2023

@OJ7 would be nice if based on subscription type Essential/Extra/Premium we could also add the other free games from the catalogs. Some of them always get removed from the catalogs so it would be great if we could also secure them in our pile of shame list of games.

@4n4n4s I don't think extra/premium provide you any other free games to keep. The purpose of this is to claim the free monthly games so that you don't lose it if you forget to claim them manually. Once a game leaves the service (for extra/premium), you lose access to it completely, even if you had it downloaded.

@4n4n4s
Copy link
Contributor

4n4n4s commented Aug 26, 2023

@OJ7 would be nice if based on subscription type Essential/Extra/Premium we could also add the other free games from the catalogs. Some of them always get removed from the catalogs so it would be great if we could also secure them in our pile of shame list of games.

@4n4n4s I don't think extra/premium provide you any other free games to keep. The purpose of this is to claim the free monthly games so that you don't lose it if you forget to claim them manually. Once a game leaves the service (for extra/premium), you lose access to it completely, even if you had it downloaded.

For any game you claim with PS+ that's the case.
Monthly free games but also the collections.

Sony removes games from the collections though that were once free for PS+ substitutions and makes them available for purchase again.

So claiming the monthly games has the same effect as claiming the collection games.

@OJ7
Copy link
Contributor Author

OJ7 commented Aug 26, 2023

For any game you claim with PS+ that's the case. Monthly free games but also the collections.

Sony removes games from the collections though that were once free for PS+ substitutions and makes them available for purchase again.

So claiming the monthly games has the same effect as claiming the collection games.

@4n4n4s not sure I fully understand. Are to saying that if you claim a game in the PS Plus Extra/Premium catalog, you still have access to it to play, even after it leaves the service? For example, according to this list, Deathloop is leaving the service next month (on Extra tier). If I add it to my library now, I'll still be able to play it after next month? I haven't tested it out with Extra/Premium, but my experience with PS Now was that you would lose access after it leaves the service (similar to Xbox Game Pass).

@4n4n4s
Copy link
Contributor

4n4n4s commented Aug 26, 2023

For any game you claim with PS+ that's the case. Monthly free games but also the collections.

Sony removes games from the collections though that were once free for PS+ substitutions and makes them available for purchase again.

So claiming the monthly games has the same effect as claiming the collection games.

@4n4n4s not sure I fully understand. Are to saying that if you claim a game in the PS Plus Extra/Premium catalog, you still have access to it to play, even after it leaves the service? For example, according to this list, Deathloop is leaving the service next month (on Extra tier). If I add it to my library now, I'll still be able to play it after next month? I haven't tested it out with Extra/Premium, but my experience with PS Now was that you would lose access after it leaves the service (similar to Xbox Game Pass).

Yes afaik. Once it's in your library and you are subscribed to PS+ you should still be able to download and play it.

@OJ7
Copy link
Contributor Author

OJ7 commented Aug 27, 2023

Yes afaik. Once it's in your library and you are subscribed to PS+ you should still be able to download and play it.

Have you been able to verify this with any game that has left the service? The PlayStation website implies this isn't true.

From the usage terms

Games downloaded to your console are playable as long as you have a valid subscription and the game remains available in the service

From the FAQ

Are PlayStation Plus games mine to keep?
Yes, for as long as you remain an active subscriber. Some games in the Game Catalogue and Classics Catalogue will have end dates when they leave the service, which will be publicised ahead of time.

@4n4n4s
Copy link
Contributor

4n4n4s commented Aug 28, 2023

@OJ7
Copy link
Contributor Author

OJ7 commented Aug 28, 2023

https://www.ign.com/articles/playstation-5s-ps-plus-collection-being-removed-in-may @OJ7

Yeah, so this was a one time thing for when you bought a PS5. Unfortunately, this isn't the same as Extra/Premium, it's more like the Essential monthly games except that it ran for a couple years.

import { cfg } from "./config.js";

// ### SETUP
const URL_CLAIM = "https://www.playstation.com/en-us/ps-plus/whats-new";
Copy link

@Barokai Barokai Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi,
could you make the locale configurable too, please? as there are different country stores, in my example, "de-at"
With en-us in the URL, I can't claim the games even when being logged in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I likely won't be able to work on this PR anytime soon. If anyone else wants to take over this PR, feel free to.

This automation is mostly working. However, sometimes the login detection/state can get in a weird state and have noticed it fail for me quite often.

  • this part for detecting page load sometimes never resolves (domcontentloaded does not always trigger)
  • if the page load does resolve, the sign in button locator may not be specific enough, sometimes (rarely) it redirects to account management page?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OJ7! The load/login I can have a look at without a Playstation Plus subscription I guess?

@Barokai I just tried that e.g. en-de does not work. If we can't list the games for a country without having to change to its language, it will be problematic for text locators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vogler yup, no subscription needed.

FYI I did some testing with another account (Turkish) and had to change it to en-tr for it to redeem games. Otherwise, there would be an unknown error redeeming them sometimes.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Barokai I just tried that e.g. en-de does not work. If we can't list the games for a country without having to change to its language, it will be problematic for text locators.

you're right en-de doesn't work as it is a non-existent locale.
didn't check all the locators to be honest, thought they were only about class and ID selectors, didn't see the text only ones - only way to solve this would be to make a lookup table for the languages and all the translations of text-only locators...

Copy link
Contributor

@4n4n4s 4n4n4s Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might push an updates version of this this weekend i have been working on some things already :)

@Mrgaton
Copy link

Mrgaton commented Apr 30, 2024

hmm

@OJ7 OJ7 closed this Apr 30, 2024
@Mrgaton
Copy link

Mrgaton commented Apr 30, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Store] PS Plus monthly games
6 participants