-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playstation Plus Monthly Games #165
Conversation
Is this going to be pulled in soon? Would make this already awesome app complete from my perspective. |
@OJ7 would be nice if based on subscription type Essential/Extra/Premium we could also add the other free games from the catalogs. Some of them always get removed from the catalogs so it would be great if we could also secure them in our pile of shame list of games. |
@4n4n4s I don't think extra/premium provide you any other free games to keep. The purpose of this is to claim the free monthly games so that you don't lose it if you forget to claim them manually. Once a game leaves the service (for extra/premium), you lose access to it completely, even if you had it downloaded. |
For any game you claim with PS+ that's the case. Sony removes games from the collections though that were once free for PS+ substitutions and makes them available for purchase again. So claiming the monthly games has the same effect as claiming the collection games. |
@4n4n4s not sure I fully understand. Are to saying that if you claim a game in the PS Plus Extra/Premium catalog, you still have access to it to play, even after it leaves the service? For example, according to this list, Deathloop is leaving the service next month (on Extra tier). If I add it to my library now, I'll still be able to play it after next month? I haven't tested it out with Extra/Premium, but my experience with PS Now was that you would lose access after it leaves the service (similar to Xbox Game Pass). |
Yes afaik. Once it's in your library and you are subscribed to PS+ you should still be able to download and play it. |
Have you been able to verify this with any game that has left the service? The PlayStation website implies this isn't true.
|
Yeah, so this was a one time thing for when you bought a PS5. Unfortunately, this isn't the same as Extra/Premium, it's more like the Essential monthly games except that it ran for a couple years. |
import { cfg } from "./config.js"; | ||
|
||
// ### SETUP | ||
const URL_CLAIM = "https://www.playstation.com/en-us/ps-plus/whats-new"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi,
could you make the locale configurable too, please? as there are different country stores, in my example, "de-at"
With en-us in the URL, I can't claim the games even when being logged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I likely won't be able to work on this PR anytime soon. If anyone else wants to take over this PR, feel free to.
This automation is mostly working. However, sometimes the login detection/state can get in a weird state and have noticed it fail for me quite often.
- this part for detecting page load sometimes never resolves (
domcontentloaded
does not always trigger) - if the page load does resolve, the sign in button locator may not be specific enough, sometimes (rarely) it redirects to account management page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vogler yup, no subscription needed.
FYI I did some testing with another account (Turkish) and had to change it to en-tr for it to redeem games. Otherwise, there would be an unknown error redeeming them sometimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Barokai I just tried that e.g. en-de does not work. If we can't list the games for a country without having to change to its language, it will be problematic for text locators.
you're right en-de doesn't work as it is a non-existent locale.
didn't check all the locators to be honest, thought they were only about class and ID selectors, didn't see the text only ones - only way to solve this would be to make a lookup table for the languages and all the translations of text-only locators...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might push an updates version of this this weekend i have been working on some things already :)
hmm |
Thanks |
Working implementation for PlayStation Plus monthly games (resolves #141).
I'm having issues with being (possibly IP) blocked from logging in due to repeated login attempts and captcha being aggressive (adding dices to match a sum, ten times in a row, and still failing every time), but this was previously working for me when I was able to login andThis has been working well for me this month and I think I got confirmation from @benwaco here as well.