Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show-build-deps does not strip trailing - version separator when using -E for hostmakedepends that exist in local repo #11740

Closed
Johnnynator opened this issue May 15, 2019 · 2 comments

Comments

@Johnnynator
Copy link
Member

System

  • xuname:
    output of xuname (part of xtools)
  • package:
    affected package(s) including the version

show-build-deps does not strip trailing - version separator when using -E for hostmakedepends that exist in local repo, this might also be an issue for makedepends but I haven't tested anything else, just sharing my observations.

Expected behavior

./xbps-src -m masterdir-musl -a armv7l show-build-deps mailimporter
cmake
extra-cmake-modules
kcoreaddons
libkdepim
python
qt5

Actual behavior

./xbps-src -E -m masterdir-musl -a armv7l show-build-deps mailimporter
/media/SourceCode/void-packages/common/xbps-src/shutils/build_dependencies.sh: line 169: unset: XBPS_BINPKG_EXISTS: cannot unset: readonly variable
/media/SourceCode/void-packages/common/xbps-src/shutils/build_dependencies.sh: line 169: unset: XBPS_BINPKG_EXISTS: cannot unset: readonly variable
/media/SourceCode/void-packages/common/xbps-src/shutils/build_dependencies.sh: line 169: unset: XBPS_BINPKG_EXISTS: cannot unset: readonly variable
/media/SourceCode/void-packages/common/xbps-src/shutils/build_dependencies.sh: line 169: unset: XBPS_BINPKG_EXISTS: cannot unset: readonly variable
/media/SourceCode/void-packages/common/xbps-src/shutils/build_dependencies.sh: line 169: unset: XBPS_BINPKG_EXISTS: cannot unset: readonly variable
/media/SourceCode/void-packages/common/xbps-src/shutils/build_dependencies.sh: line 169: unset: XBPS_BINPKG_EXISTS: cannot unset: readonly variable
/media/SourceCode/void-packages/common/xbps-src/shutils/build_dependencies.sh: line 169: unset: XBPS_BINPKG_EXISTS: cannot unset: readonly variable
cmake
extra-cmake-modules-
kcoreaddons-
libkdepim
python
qt5

Steps to reproduce the behavior

TODO: explain a simple case to reproduce it :)

@CameronNemo
Copy link
Contributor

Should also affect show-makedepends and show-hostmakedepends.

pbui added a commit to pbui/void-packages that referenced this issue May 22, 2019
srcpkg_get_version and srcpkg_get_pkgver require unsetting
XBPS_BINPKG_EXISTS to work properly (e.g. without it, some packages have
a trailing -).  Unfortunately, bash does not allow unsetting readonly
variables, which XBPS_BINPKG_EXISTS is exported as in xbps-src.

To resolve this problem, simply export XBPS_BINPKG_EXISTS as a normal
variable rather than marking it as readonly.  This addresses void-linux#11740.
Hoshpak pushed a commit that referenced this issue Jun 4, 2019
srcpkg_get_version and srcpkg_get_pkgver require unsetting
XBPS_BINPKG_EXISTS to work properly (e.g. without it, some packages have
a trailing -).  Unfortunately, bash does not allow unsetting readonly
variables, which XBPS_BINPKG_EXISTS is exported as in xbps-src.

To resolve this problem, simply export XBPS_BINPKG_EXISTS as a normal
variable rather than marking it as readonly.  This addresses #11740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@CameronNemo @Johnnynator and others