export XBPS_BINPKG_EXISTS rather than mark it as readonly #11874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srcpkg_get_version and srcpkg_get_pkgver require unsetting XBPS_BINPKG_EXISTS to work properly (e.g. without it, some packages have a trailing -). Unfortunately, bash does not allow unsetting readonly variables, which XBPS_BINPKG_EXISTS is exported as in xbps-src. To resolve this problem, simply export XBPS_BINPKG_EXISTS as a normal variable rather than marking it as readonly. This addresses void-linux#11740.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srcpkg_get_version and srcpkg_get_pkgver require unsetting
XBPS_BINPKG_EXISTS to work properly (e.g. without it, some packages have
a trailing -). Unfortunately, bash does not allow unsetting readonly
variables, which XBPS_BINPKG_EXISTS is exported as in xbps-src.
To resolve this problem, simply export XBPS_BINPKG_EXISTS as a normal
variable rather than marking it as readonly. This addresses #11740.