Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: vscodium-bin-1.33.0 #10640

Closed
wants to merge 16 commits into from
Closed

New package: vscodium-bin-1.33.0 #10640

wants to merge 16 commits into from

Conversation

shizonic
Copy link
Contributor

@shizonic shizonic commented Apr 6, 2019

Closes #10582

@shizonic shizonic force-pushed the vscodium-bin branch 2 times, most recently from e53cb62 to 5c1ceb0 Compare April 7, 2019 04:51
@hacktivista
Copy link

You will need to map libGLESv2.so, the same as vscode package.

void-packages/common/shlibs

Line 130 in c6eaa81

libGLESv2.so vscode-1.36.1_1

@shizonic shizonic force-pushed the vscodium-bin branch 5 times, most recently from 8450860 to efc886b Compare September 12, 2019 10:53
@shizonic shizonic force-pushed the vscodium-bin branch 3 times, most recently from 1752b90 to 25c0ec3 Compare October 17, 2019 06:30
@shizonic shizonic force-pushed the vscodium-bin branch 2 times, most recently from fa613da to 93933c0 Compare February 14, 2020 11:55
@travankor
Copy link
Contributor

@shizonic superseded by #18314?

@shizonic shizonic force-pushed the vscodium-bin branch 2 times, most recently from e58ac34 to c8fb642 Compare April 16, 2020 08:07
@Piraty
Copy link
Member

Piraty commented May 15, 2020

@shizonic please squash all commits to only the one 'new package'

Piraty
Piraty requested changes May 15, 2020
View reviewed changes
srcpkgs/vscodium-bin/template
nostrip_files="codium"

do_install() {
sed -i 's,/usr/share/codium,/usr/lib/vscodium,g' bin/codium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsed please

Piraty
Piraty requested changes May 15, 2020
View reviewed changes
srcpkgs/vscodium-bin/template
sed -i 's,/usr/share/codium,/usr/lib/vscodium,g' bin/codium

vmkdir usr/lib/vscodium
vcopy * usr/lib/vscodium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quote the glob

@Johnnynator
Copy link
Member

There is no point in adding a -bin package once #21758 . Also I'm not sure how much we actually need vscodium at all. Our vscode package has telemetry already disabled.

@Piraty
Copy link
Member

Piraty commented May 16, 2020

i wasn't aware. sounds reasonable, thanks @Johnnynator

@Piraty Piraty closed this May 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Duncaen Duncaen Duncaen left review comments

@Piraty Piraty Piraty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package Request: vscodium
6 participants
@shizonic @hacktivista @travankor @Piraty @Johnnynator @Duncaen