Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system wide electron package #21758

Closed
wants to merge 2 commits into from
Closed

Conversation

Johnnynator
Copy link
Member

@Johnnynator Johnnynator commented May 8, 2020

Test repo: https://void.johnnynator.dev/electron/

to do: reintroduce system zlib patch
to do: electron8 package for all the other electron apps
to do: bring the template more in line with the chromium one stile wise

Thanks to @Cogitri who did prepare most of this work

P.s. I'm already sorry for the build server to get a 3rd chromium package to build occasionally.

srcpkgs/vscode/template Outdated Show resolved Hide resolved
@Anachron
Copy link
Contributor

Anachron commented May 8, 2020

Pretty impressive. I wonder if we can find something better than _electronver=7.2.3.

@ericonr
Copy link
Member

ericonr commented May 8, 2020

Should the xbps-src config commit be here?

@Johnnynator Johnnynator force-pushed the electron branch 3 times, most recently from d75189d to a60e697 Compare May 9, 2020 17:04
@Johnnynator
Copy link
Member Author

Pretty impressive. I wonder if we can find something better than _electronver=7.2.3.

I could workaround by using

_electronver=$(xbps-uhelper version electron7)
_electronver=${_electronver%_*}

on top of every function

@fosslinux
Copy link
Contributor

Nice! What's the current status?

@Johnnynator
Copy link
Member Author

The current status are 2 things:
a) Wasn't able to figure cross out yet (also counts for chromium) (Would give more justification for this)
b) I'm kinda hesitant at more packages to the repo that take 12h to build on the build servers. But I also dislike shipping upstream binaries if not needed.

@fosslinux
Copy link
Contributor

a) Fair enough -- I am looking at chromium cross myself actually, but it isn't trivial.
b) I get that but IMO it's better than shipping upstream binaries...

@Johnnynator Johnnynator marked this pull request as ready for review July 17, 2020 11:43
@Johnnynator Johnnynator changed the title [really wip] system wide electron package system wide electron package Jul 18, 2020
@Johnnynator
Copy link
Member Author

Johnnynator commented Jul 18, 2020

@void-linux/pkg-committers Any comments adding a few more chromium version to the repo? (a few more = up to 3 more or so)

@Duncaen
Copy link
Member

Duncaen commented Jul 18, 2020

imho better than adding binary packages.

Johnnynator added a commit to Johnnynator/void-packages that referenced this pull request Jul 21, 2020
@Chocimier Chocimier mentioned this pull request Aug 3, 2020
@fosslinux
Copy link
Contributor

Any way for me to help? I really would like this package

a) Wasn't able to figure cross out yet (also counts for chromium) (Would give more justification for this)

Regarding cross, I think its OK for now for it to be nocross and come back to it when we figure out chromium cross, I don't think it needs to be a blocker.

Johnnynator added a commit to Johnnynator/void-packages that referenced this pull request Aug 16, 2020
@fosslinux
Copy link
Contributor

Woo!

@kedodrill
Copy link
Contributor

Woo!

Bit confused here, as this is closed I assume it did not make it into master? Or is the push / merge process different somehow?

@Duncaen
Copy link
Member

Duncaen commented Nov 4, 2020

The PR was closed with a commit bb5f851.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron 🤮 Electron package request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants