Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: python3-weasyprint #13211

Closed
wants to merge 9 commits into from
Closed

Conversation

grafov
Copy link
Contributor

@grafov grafov commented Jul 18, 2019

Weasyprint used for example by Pandoc as a printing engine. It could be used as a standalone HTML convertor too.

Also the package add dependencies that missed in Void yet:

  • python3-cairosvg
  • python3-tinycss2
  • python3-cssselect2
  • python3-pyphen

@Hoshpak
Copy link
Member

Hoshpak commented Jul 19, 2019

I havent reviewed the changes themselves yet but this PRs git history is already making it unfit for merge. Please revise the PR so that only the "New package:" commits are part of the branch, especially the merge commits need to go.

If you feel the need to pull in changes from master in the future while working on your branch, please use rebase instead of merge. It will pull the commits from master and then add your commits at the top, avoiding merge commits.

@@ -0,0 +1,16 @@
# Template file for 'python3-cairosvg'
pkgname=python3-cairosvg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use same case as upstream: CairoSVG

Copy link
Member

@Chocimier Chocimier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add checkdepends="${depends}" for WeasyPrint and python3-CairoSVG at least.

I would also remove "python" word from short_desc where sensible.

build_style=python3-module
pycompile_module="cairosvg"
hostmakedepends="python3-setuptools"
depends="python3-cairocffi python3-Pillow python3-defusedxml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also cairo

hostmakedepends="python3-setuptools"
short_desc="CSS selectors for Python3 ElementTree"
maintainer="Alexander I.Grafov <grafov@gmail.com>"
license="3-clause-BSD"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPDX names that BSD-3-Clause

@@ -0,0 +1,15 @@
# Template file for 'python3-pyphen'
pkgname=python3-pyphen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3-Pyphen

@@ -0,0 +1,20 @@
# Template file for 'python3-weasyprint'
pkgname=python3-weasyprint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is mainly comandline tool, name should be WeasyPrint.

version=48
revision=1
archs=noarch
wrksrc="WeasyPrint-${version}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove wrksrc= after rename

build_style=python3-module
pycompile_module="weasyprint"
hostmakedepends="python3-setuptools"
depends="python3-cffi python3-html5lib python3-cssselect2 python3-pyphen python3-cairosvg python3-tinycss2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pango

build_style=python3-module
pycompile_module="weasyprint"
hostmakedepends="python3-setuptools"
depends="python3-cffi python3-html5lib python3-cssselect2 python3-pyphen python3-cairosvg python3-tinycss2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also python3-setuptools in depends

@travankor
Copy link
Contributor

inactive?

@ericonr
Copy link
Member

ericonr commented Nov 1, 2020

Seems to be the case

@ericonr ericonr closed this Nov 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants