-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: python3-weasyprint #13211
Conversation
Sync with upstream
I havent reviewed the changes themselves yet but this PRs git history is already making it unfit for merge. Please revise the PR so that only the "New package:" commits are part of the branch, especially the merge commits need to go. If you feel the need to pull in changes from master in the future while working on your branch, please use rebase instead of merge. It will pull the commits from master and then add your commits at the top, avoiding merge commits. |
@@ -0,0 +1,16 @@ | |||
# Template file for 'python3-cairosvg' | |||
pkgname=python3-cairosvg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use same case as upstream: CairoSVG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add checkdepends="${depends}"
for WeasyPrint and python3-CairoSVG at least.
I would also remove "python" word from short_desc where sensible.
build_style=python3-module | ||
pycompile_module="cairosvg" | ||
hostmakedepends="python3-setuptools" | ||
depends="python3-cairocffi python3-Pillow python3-defusedxml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also cairo
hostmakedepends="python3-setuptools" | ||
short_desc="CSS selectors for Python3 ElementTree" | ||
maintainer="Alexander I.Grafov <grafov@gmail.com>" | ||
license="3-clause-BSD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPDX names that BSD-3-Clause
@@ -0,0 +1,15 @@ | |||
# Template file for 'python3-pyphen' | |||
pkgname=python3-pyphen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python3-Pyphen
@@ -0,0 +1,20 @@ | |||
# Template file for 'python3-weasyprint' | |||
pkgname=python3-weasyprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is mainly comandline tool, name should be WeasyPrint.
version=48 | ||
revision=1 | ||
archs=noarch | ||
wrksrc="WeasyPrint-${version}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove wrksrc= after rename
build_style=python3-module | ||
pycompile_module="weasyprint" | ||
hostmakedepends="python3-setuptools" | ||
depends="python3-cffi python3-html5lib python3-cssselect2 python3-pyphen python3-cairosvg python3-tinycss2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also pango
build_style=python3-module | ||
pycompile_module="weasyprint" | ||
hostmakedepends="python3-setuptools" | ||
depends="python3-cffi python3-html5lib python3-cssselect2 python3-pyphen python3-cairosvg python3-tinycss2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also python3-setuptools in depends
inactive? |
Seems to be the case |
Weasyprint used for example by Pandoc as a printing engine. It could be used as a standalone HTML convertor too.
Also the package add dependencies that missed in Void yet: