-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer versioned .so files in libgssglue dependencies list #13331
Conversation
What brought you to this conclusion? Generally it's the other way around. Putting the symlink into |
I believe it is by It should instead list |
On 2019-07-25 11:17:42 -0700, Jürgen Buchmüller wrote:
I believe it is by `/etc/gssapi_mech.conf` from the package
`libgssglue` which lists `/usr/lib/libgssapi_krb5.so` in its default
config.
It should instead list `/usr/lib/libgssapi_krb5.so.2` and be updated
whenever the major version changes.
I think this is the correct direction,
I'll update libgssglue instead.
…--
Danh
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, please just add a note to mit-krb5
to update the soname in libgssglue when the soname of the library is bumped, otherwise things like that tend to be forgotten. You can find an example in the thunderbird
package, the template revision does not need to be bumped for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the revision of libgssglue
, otherwise the builders won't pick the change up. The change to each package should be in its own separate commit (one for libgssglue and one for mit-krb5) and the comment in mit-krb5 should be before pkgname
.
libgssglue will load those shared-object files on-demand. Quote from Pozimski: > if some software requires the unversioned symlink, > it's doing it wrong
libgssglue requires versioned .so file. Add a comment to remind people update libgssglue if there's a major version change.
rdesktop requires /usr/lib/libgssapi_krb5.so,
that file should come with mit-krb5-libs instead of mit-krb5-devel.