Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer versioned .so files in libgssglue dependencies list #13331

Merged
merged 2 commits into from
Jul 28, 2019

Conversation

sgn
Copy link
Member

@sgn sgn commented Jul 25, 2019

rdesktop requires /usr/lib/libgssapi_krb5.so,
that file should come with mit-krb5-libs instead of mit-krb5-devel.

@Hoshpak
Copy link
Member

Hoshpak commented Jul 25, 2019

What brought you to this conclusion? Generally it's the other way around. Putting the symlink into -devel is correct and if some software requires the unversioned symlink, it is doing it wrong.

@pullmoll
Copy link
Member

pullmoll commented Jul 25, 2019

I believe it is by /etc/gssapi_mech.conf from the package libgssglue which lists /usr/lib/libgssapi_krb5.so in its default config, a file we ship.

It should instead list /usr/lib/libgssapi_krb5.so.2 and be updated whenever the major version changes.

@sgn
Copy link
Member Author

sgn commented Jul 26, 2019 via email

Copy link
Member

@Hoshpak Hoshpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please just add a note to mit-krb5 to update the soname in libgssglue when the soname of the library is bumped, otherwise things like that tend to be forgotten. You can find an example in the thunderbird package, the template revision does not need to be bumped for that.

@sgn sgn changed the title mit-krb5: move /usr/lib/*.so to -libs subpackage prefer versioned .so files in libgssglue dependencies list Jul 27, 2019
Copy link
Member

@Hoshpak Hoshpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the revision of libgssglue, otherwise the builders won't pick the change up. The change to each package should be in its own separate commit (one for libgssglue and one for mit-krb5) and the comment in mit-krb5 should be before pkgname.

sgn added 2 commits July 28, 2019 16:02
libgssglue will load those shared-object files on-demand.
Quote from Pozimski:
> if some software requires the unversioned symlink,
> it's doing it wrong
libgssglue requires versioned .so file.
Add a comment to remind people update libgssglue if there's a major
version change.
@Hoshpak Hoshpak merged commit 4cdd4a3 into void-linux:master Jul 28, 2019
@sgn sgn deleted the mit-krb5 branch October 24, 2019 16:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants