Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3D STEP file support for kicad #17844

Closed
wants to merge 3 commits into from

Conversation

groundstack
Copy link

With these changes I was able to compile kicad with support for 3D step model rendering.

Related to this issue:
#17818

I am new to void linux, first patch I submit, let's see if I am doing this properly :)

srcpkgs/kicad/template Outdated Show resolved Hide resolved
Co-Authored-By: John Zimmermann <johnz@posteo.net>
@groundstack
Copy link
Author

My architecture is x86_64 musl.

Looking at the log from Travis CI it timed out around 90% of the compilation job. Seems same for glibc. What's next step??

Copy link
Contributor

@ndowens ndowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to do a revision bump, since this will change more than just template cosmetics and such. If a change will change functionality, or need to build in general, then do revbumps

@groundstack
Copy link
Author

Who does the rev bump? I don't know how or if I can do it.

Arch linux includes the OCE / Step functionality by default, as it is important feature to interface with mechanical engineers.

@ndowens
Copy link
Contributor

ndowens commented Dec 30, 2019

You do, by editing the template file

@groundstack
Copy link
Author

I've added revision number change. The bot tried to compile again, times out at 50 min where it is about 90%. How do we increase the compilation time?

@ndowens
Copy link
Contributor

ndowens commented Dec 31, 2019 via email

@ericonr ericonr mentioned this pull request May 18, 2020
@ericonr
Copy link
Member

ericonr commented May 18, 2020

@groundstack the recommended OpenCascade library for KiCad is the OCC one (provided by the occt package). The reason KiCad wasn't built with STEP support was due to lacking the proper CMake config flag. I'm fixing these issues in my PR, along with updating KiCad.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants