-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v0.10.9 release, fix URLs, add dependencies #18306
Conversation
bad commit message |
@q66 Thanks, and I'll fix the commit message, but this actually has bigger problems. Like I don't know what to do with all the new deps that are missing Void packages. This is going to need some help from somebody more in the know than myself. I'll collaborate with what I know of SILE (and can fix upstream). |
you're going to have to either package the dependencies (preferable) or somehow vendor them (the worse option) |
@q66 There is already a vendor option built in. If Void people want this package to go that way all that has to happen is drop the assorted Lua package dependencies, make sure I don't actually use Void Linux and don't care which way this goes, I'm just trying to facilitate downstream packages getting updated. |
I'm happy to facilitate this update going through, but I'm kind of shooting in the dark. Maybe somebody familiar with the system can help and I can answer questions along the way. Between v0.10.2 and v0.10.3 there were some upstream packaging changes such as using more standard locations for Does anybody know what the logic to using Lua 5.1 for this was? Can I help get it moved to Lua 5.3 (or luajit) and all the required libraries packaged? |
Any movement on getting this finished? |
@abenson I'm kind of stuck, not being on Void myself. This needs some attention for somebody with a little experience on the platform. I'm happy to help and I know the SILE and Lua sides of things, but somebody with Void packaging chops needs to step in to get this through. Have any yourself? |
If anybody that works on Void wants to work with me to get this updated I'm still out here and willing to help. I can talk somebody through the upstream changes and what Lua things need to be in place for this version bump to work. |
Fixes upstream URLs, add new dependencies (not all packaged yet, needs other upstream work.)
makedepends="fontconfig-devel harfbuzz-devel icu-devel lua54 lua54-cassowary | ||
lua54-cosmo lua54-linenoise lua54-lpeg lua54-zlib lua54-cliargs | ||
lua54-luaepnf lua54-luaexpat lua54-luafilesystem lua54-repl lua54-luasec | ||
lua54-luasocket lua54-penlight lua54-stdlib lua54-vstruct" | ||
depends="fonts-sil-gentium libtexpdf lua54 lua54-cassowary lua54-cosmo | ||
lua54-linenoise lua54-lpeg lua54-zlib lua54-cliargs lua54-luaepnf | ||
lua54-luaexpat lua54-luafilesystem lua54-repl lua54-luasec lua54-luasocket | ||
lua54-penlight lua54-stdlib lua54-vstruct" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put all the common dependencies in a _luadeps
variable above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do. Unfortunately some of these Lua packages don't exist yet on Void, I think that's the main thing holding up this PR.
Well, fwiw @Johnnynator |
Seemingly abandoned. |
--with-system-luarocks
. Note this is a new option since the last release, not the default, but probably an option in keeping with Void Linux MO.Some of these Lua packages that are missing were required by the previous version too (e.g. stdlib) so I'm not sure what's going on here.
If there is anything we can do upstream in SILE to make packaging easier let me know, I'm happy to facilitate a point release if