Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybind11 #18873

Closed
wants to merge 3 commits into from
Closed

Pybind11 #18873

wants to merge 3 commits into from

Conversation

sanderboer
Copy link

No description provided.

}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally added an empty line at the end of the template.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the license should be BSD-3-Clause

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed these, thank you.

@NeelChotai
Copy link
Contributor

NeelChotai commented Feb 11, 2020

I don't think this should require the python3 prefix, you could remove that and the wrksrc line.

short_desc should read lightweight header-only library that exposes C++ types in Python and vice versa

Cross-compilation errors may be related to pybind/pybind11#1330 and pybind/pybind11#99.

checksum=1eed57bc6863190e35637290f97a20c81cfe4d9090ac0a24f3bbf08f265eb71d

post_install(){
vlicense LICENSE LICENSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vlicense LICENSE is sufficient

@yopito
Copy link
Contributor

yopito commented Mar 5, 2020

I have a WIP that is crossbuilding with these:

build_style=cmake
configure_args="-DPYTHON_EXECUTABLE=/usr/bin/python3"
hostmakedepends="python3-devel python3-pytest"
makedepends="python3-devel boost-devel"

short_desc="A lightweight header-only library that exposes C++ types in Python and vice versa."
maintainer="Sander Boer <sanderboer@mauc.nl>"
license="BSD-3-Clause"
homepage="https://github.com/pybind/pybind11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homepage="https://pybind11.readthedocs.io/en/latest", no ?

@gspe
Copy link
Contributor

gspe commented Mar 10, 2020

This template doesn't build python files and has unnecessary dependency depends="boost python3"

The follow template works, and should cross-compile:

# Template file for 'pybind11'
pkgname=pybind11
version=2.4.3
revision=1
build_style=cmake
configure_args="-D PYTHON_INCLUDE_DIR=ON -D PYBIND11_MASTER_PROJECT=ON -D PYBIND11_TEST=OFF"
hostmakedepends="python3-devel python3-setuptools"
makedepends="python3-devel"
short_desc="Seamless operability between C++11 and Python"
maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
license="BSD-3-Clause"
homepage="https://pybind11.readthedocs.io"
distfiles="https://github.com/pybind/${pkgname}/archive/v${version}.tar.gz"
checksum=1eed57bc6863190e35637290f97a20c81cfe4d9090ac0a24f3bbf08f265eb71d

# build python package
post_build() {
	# cmake already install pybind11 headers
	export PYBIND11_USE_CMAKE=ON

	python3 setup.py build

	python3 setup.py install --prefix=/usr --root=${DESTDIR}
}

post_install() {
	vlicense LICENSE
}

@ahesford
Copy link
Member

This is resolved by #20218; the CMake modules are fundamentally broken in pybind11 and, until they are fixed upstream, are excluded from the Void project. Upstream issue #2139 tracks this problem.

@Chocimier Chocimier closed this May 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants