Add .desktop files for CLion and IDEA Ultimate #22687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2xsaiko
force-pushed
the
jetbrains-desktop-files
branch
from
e50bab7
to
81cf7c6
Compare
|
I'm not sure we want to vendor these in :/ Do they noticeably improve the workflow? |
ericonr
reviewed
Sep 29, 2020
Comment on lines
+80
to
+81
| install -Dm644 ${FILESDIR}/jetbrains-clion.desktop -t $DESTDIR/usr/share/applications | ||
| ln -sf /${TARGET_PATH}/bin/clion.svg ${DESTDIR}/usr/share/pixmaps/clion.svg |
There was a problem hiding this comment.
You should use vinstall, it will create the directory for you.
|
Files like these should not be vendored, if upstream distributes them then we can install them, but we should not add custom files for Void here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also creates a symlink for the program icons.