Update gcompat to 0.9.0, use dynamic musl-obstack #23432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
changed the title
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
Add musl-obstack dependency. Close: void-linux#23432
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
sgn
pushed a commit
to sgn/void-packages
that referenced
this pull request
Jul 7, 2020
|
This fixes my issue (#22616) perfectly, thank you so much! 🎉 I had to create a musl-obstack-devel symlink for it to build. Looks like the CI is having the same issue with finding the musl-obstack-devel package too. |
|
Oof, I think I forgot to commit that. Thanks! |
ericonr
force-pushed
the
gcompat
branch
3 times, most recently
from
9653f5a
to
6ebb9f2
Compare
|
One other option is pulling musl-obstack as another distfile for gcompat, which can then be included as part of the gcompat package. That way, we avoid messing with all the other packages using static musl-obstack. |
ericonr
force-pushed
the
gcompat
branch
2 times, most recently
from
a0519c1
to
3675c1b
Compare
ericonr
changed the title
ericonr
changed the title
|
Removed Spotify from the PR, that's going to be a separate project. |
|
Pinging @pullmoll about the change to musl-obstack. |
ericonr
force-pushed
the
gcompat
branch
2 times, most recently
from
3ba41fc
to
2edb889
Compare
Add musl-obstack dependency.
|
@ericonr sure, go ahead. |
pullmoll
reviewed
Jul 28, 2020
|
Thanks! |
|
@ericonr Feel free, I do not use void anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so this is a biggie PR, and I do need help for making some decisions.
gcompatcan do Spotify now, on Adélie. I am working on debugging it on Void, because it isn't working completely yet. If I can't get it working soon, I will leave the spotify commit out of this one.obstackingcompat, by enabling the dynamic lib inmusl-obstack. This completely fixes Missing obstack symbols for arduino-cli binaries on musl #22616, which needed obstack and__strftime_lsymbols (the latter was fixed by gcompat itself).musl-obstack-devel.musl-obstack-devel, but they ended up depending on the dynamic version of obstack. Is this bad? Is there some way to solve this? Perhaps two devel sub packages, one for dynamic and one for static linking?