Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsigrok: update to 0.5.2. #23581

Closed
wants to merge 1 commit into from

Conversation

Gigahawk
Copy link
Contributor

Fixes #23580

@Gigahawk
Copy link
Contributor Author

Original udev rule uses TAG+=uaccess which doesn't seem to be supported due to not using systemd-logind.

The repo provides a similar rules file that allows access for users in the plugdev group which is usually only present on Debian based distros, so I've made a copy of it for the dialout group instead.

Not sure if it's preferred to patch an existing file or to use some group other than dialout.

@sgn
Copy link
Member

sgn commented Jul 17, 2020

Original udev rule uses TAG+=uaccess which doesn't seem to be supported due to not using systemd-logind.

Doesn't elogind provide systemd-logind? airspy, hackrf, and libnfc patched plugdev to uaccess, so, it should works already.

The repo provides a similar rules file that allows access for users in the plugdev group which is usually only present on Debian based distros, so I've made a copy of it for the dialout group instead.

Not sure if it's preferred to patch an existing file or to use some group other than dialout.

libu2f-host patches:

s:GROUP="plugdev":GROUP="users":

@Gigahawk
Copy link
Contributor Author

Ok, I've switched to patching the plugdev file.

As for elogind it shouldn't be assumed that all users are using a login manager.
My personal setup is just a tty login with an .xinitrc that starts my window manager.

Comment on lines +18 to +19
-ENV{ID_SIGROK}=="1", MODE="660", GROUP="plugdev"
+ENV{ID_SIGROK}=="1", MODE="660", GROUP="users"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, openocd has a plugdev group. Maybe we could add that or make a small package that only adds the plugdev group? And then everything that uses it can depend on the plugdev meta-package.

@paper42
Copy link
Member

paper42 commented Sep 20, 2021

done in 179065f without the patch, do we still need it?

@0x5c
Copy link
Contributor

0x5c commented Mar 14, 2022

@ericonr There's a couple packages that have system_groups="plugdev", are they currently conflicting? If not, then the solution would simply be to add that line to libsigrok. There's also similar-ish kinds of packages (SDRs like hackrf and airspy) that apply a patch like this PR, but that seems a tad hacky to me.

As an asside, some of the packages that add plugdev do not have an INSTALL.msg file informing of the need to be in the group, should they have one added?

0x5c added a commit to 0x5c/void-packages that referenced this pull request Mar 14, 2022
@0x5c
Copy link
Contributor

0x5c commented Mar 14, 2022

@Gigahawk I made #36144 which takes a different approach: it creates the group and adds an install message indicating that you need to be added to the group. Does it work for you?

@Gigahawk
Copy link
Contributor Author

@Gigahawk I made #36144 which takes a different approach: it creates the group and adds an install message indicating that you need to be added to the group. Does it work for you?

Yea that's fine, should I close this PR?

@0x5c
Copy link
Contributor

0x5c commented Mar 14, 2022

The actual update has already been merged so if you feel the other approach to the fix is adequate, probably

0x5c added a commit to 0x5c/void-packages that referenced this pull request Mar 20, 2022
0x5c added a commit to 0x5c/void-packages that referenced this pull request Mar 29, 2022
0x5c added a commit to 0x5c/void-packages that referenced this pull request Apr 6, 2022
abenson pushed a commit that referenced this pull request Apr 7, 2022
@0x5c
Copy link
Contributor

0x5c commented Apr 7, 2022

@Gigahawk Both parts of the fix have been merged, so once you get the libsigrok and the base-files update you should have a new plugdev group on your machine. After adding it to your user (usermod -aG plugdev <username>, followed by logging back in), sigrok should be working without the need for sudo.

@Gigahawk
Copy link
Contributor Author

Gigahawk commented Apr 7, 2022

@Gigahawk Both parts of the fix have been merged, so once you get the libsigrok and the base-files update you should have a new plugdev group on your machine. After adding it to your user (usermod -aG plugdev <username>, followed by logging back in), sigrok should be working without the need for sudo.

Thanks!

basploeger pushed a commit to basploeger/void-packages that referenced this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libsigrok] 61-libsigrok-uaccess.rules udev rule doesn't work correctly
5 participants