Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsigrok: fix missing udev rules #36144

Merged
merged 1 commit into from Apr 7, 2022
Merged

Conversation

0x5c
Copy link
Contributor

@0x5c 0x5c commented Mar 14, 2022

Fixes #23580
Closes #23581 (obsoletes the PR)

Testing the changes

  • I tested the changes in this PR: YES

This PR is dependent on #36238 being merged.

@Duncaen
Copy link
Member

Duncaen commented Mar 15, 2022

Please no INSTALL.msg for this, if this needs documentation, add a README.void instead.

@q66
Copy link
Contributor

q66 commented Mar 15, 2022

i don't really like this idea, IMO we should add plugdev to default groups in base-files (in debian it's gid 46, here we could simply add it among the base groups (after input, before nogroup) and for existing setups, put a groupadd in an upgrade hook)

either that, or change the udev files here to use another, existing group

@0x5c
Copy link
Contributor Author

0x5c commented Mar 15, 2022

i don't really like this idea, IMO we should add plugdev to default groups in base-files (in debian it's gid 46, here we could simply add it among the base groups (after input, before nogroup) and for existing setups, put a groupadd in an upgrade hook)

either that, or change the udev files here to use another, existing group

That would be cleaner it seems and would allow cleanup in many templates, but can this be done without breaking current installations? The plugdev group already exist with a different GID for many users, will the change take that into account?

@0x5c 0x5c marked this pull request as draft March 17, 2022 22:46
@0x5c
Copy link
Contributor Author

0x5c commented Mar 20, 2022

I realised that the original fix in this PR was bogus resulting from improper testing.

With #36238 taking care of adding the plugdev group, we still need to have the package install the missing udev rules. This PR has been updated to do that. It has been successfully tested on a machine that does not have elogind.

This PR is dependent on #36238 being merged.

@0x5c 0x5c changed the title libsigrok: fix missing plugdev group libsigrok: fix missing udev rules Mar 20, 2022
@0x5c 0x5c marked this pull request as ready for review March 20, 2022 05:15
@abenson abenson merged commit 7d9c9b2 into void-linux:master Apr 7, 2022
@0x5c 0x5c deleted the sigrok-plugdev branch April 7, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libsigrok] 61-libsigrok-uaccess.rules udev rule doesn't work correctly
4 participants