Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroot-style/uchroot: add -t parameter to command. #24314

Closed
wants to merge 1 commit into from

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Aug 17, 2020

Without it, using xbps-src with overlay errors out with the message
below:

ERROR: failed to mount overlayfs on
/home/ericonr/void/void-packages/masterdir.XXXXdMemKO/masterdir (Invalid
argument)


I don't know if I'm the only one seeing this.

Without it, using xbps-src with overlay errors out with the message
below:

ERROR: failed to mount overlayfs on
/home/ericonr/void/void-packages/masterdir.XXXXdMemKO/masterdir (Invalid
argument)
@q66
Copy link
Contributor

q66 commented Sep 3, 2020

overlayfs is not supported on zfs

@q66 q66 closed this Sep 3, 2020
@ericonr ericonr deleted the uchroot branch September 3, 2020 13:21
@pullmoll
Copy link
Member

pullmoll commented Sep 3, 2020

Perhaps chroot-style/uchroot can check the mount point's filesystem and error out if with an explicit message.
Some lines using findmnt from util-linux can be used to tell a path's file system:

#!/bin/bash
path=$PWD
while [ -z "$FSTYPE" -a ! -z "$path" ]; do
	eval $(findmnt -P "$path")
	path="${path%/*}"
done
echo "$FSTYPE"

@ericonr
Copy link
Member Author

ericonr commented Sep 3, 2020

@pullmoll perhaps to avoid adding complexity to the script itself, we could add a message that -t might not work on all filesystems...

@pullmoll
Copy link
Member

pullmoll commented Sep 3, 2020

@ericonr Agree.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants