Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbps-src: expand note about -t flag. #24643

Merged
merged 1 commit into from
Sep 3, 2020
Merged

xbps-src: expand note about -t flag. #24643

merged 1 commit into from
Sep 3, 2020

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Sep 3, 2020

Related to #24314

@q66
Copy link
Contributor

q66 commented Sep 3, 2020

afaik there is work in progress to support renameat2 in zfs, so this might not be true after a while

@ericonr
Copy link
Member Author

ericonr commented Sep 3, 2020

Made it more generic, then.

@q66
Copy link
Contributor

q66 commented Sep 3, 2020

the wording makes it sound like they are two separate things, i'd reword it it a bit, something like "This flag requires xbps-uchroot(1), so it won't work..."

@ericonr
Copy link
Member Author

ericonr commented Sep 3, 2020

I'm not sure it's fully related... If you set XBPS_CHROOT_CMD=uchroot in etc/conf, things still work just fine, unless you also add -t to the xbps-src command line. So it's not because you're using xbps-uchroot, it's because you're using overlayfs.

@q66
Copy link
Contributor

q66 commented Sep 3, 2020

hm, you're right i guess...

@q66 q66 merged commit 5f3dd33 into void-linux:master Sep 3, 2020
@ericonr ericonr deleted the chr branch September 6, 2020 21:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants