Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: loudgain-0.6.8 #24400

Closed
wants to merge 1 commit into from
Closed

New package: loudgain-0.6.8 #24400

wants to merge 1 commit into from

Conversation

motorto
Copy link
Contributor

@motorto motorto commented Aug 21, 2020

Asked on #23054

version=0.6.8
revision=1
build_style=cmake
hostmakedepends="libebur128-devel ffmpeg-devel libavcodec libavformat libavutil libswresample libebur128 taglib-devel pkg-config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makedepends="libebur128-devel ffmpeg-devel taglib-devel"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply replacing hostmakedepends into makedepends does the trick . Or what you are saying is that that's the only packages needed and the rest is redundant

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the rest is redundant. For example, libavcodec is a dependency of ffmpeg-devel.

Copy link
Contributor Author

@motorto motorto Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure ? Adding this:

Suggested change
hostmakedepends="libebur128-devel ffmpeg-devel libavcodec libavformat libavutil libswresample libebur128 taglib-devel pkg-config"
makedepends="libebur128-devel ffmpeg-devel taglib-devel"

And then xbps-src package:

=> loudgain-0.6.8_1: running do_configure ...
-- Checking for module 'libavcodec'
--
CMake Error at /usr/share/cmake-3.17/Modules/FindPkgConfig.cmake:497 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake-3.17/Modules/FindPkgConfig.cmake:681 (_pkg_check_modules_internal)
CMakeLists.txt:27 (PKG_CHECK_MODULES)
-- Configuring incomplete, errors occurred!
See also "/builddir/loudgain-0.6.8/build/CMakeFiles/CMakeOutput.log".
=> ERROR: loudgain-0.6.8_1: do_configure: 'CFLAGS="${CFLAGS/ -pipe / }" CXXFLAGS="${CXXFLAGS/ -p's|[^/]*||g' -e 's|/|../|g')' exited with 1
=> ERROR: in do_configure() at `common/build-style/cmake.sh:62

EDIT:

Suggested change
hostmakedepends="libebur128-devel ffmpeg-devel libavcodec libavformat libavutil libswresample libebur128 taglib-devel pkg-config"
makedepends="libebur128-devel ffmpeg-devel taglib-devel libavcodec pkg-config"

This makes it work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg-config should be in hostmakedepends. Please go back read Manual

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had read the manual , but I will definitely read this time with more attention.Really appreciate your help !

srcpkgs/loudgain/template Outdated Show resolved Hide resolved
@motorto
Copy link
Contributor Author

motorto commented Sep 4, 2020

Hey @Duncaen could you re review it again and if it ready push accept it ?

srcpkgs/loudgain/template Outdated Show resolved Hide resolved
@motorto
Copy link
Contributor Author

motorto commented Sep 4, 2020

Thanks for the insight wasn't aware of that. @Duncaen

@motorto motorto requested a review from Duncaen October 7, 2020 21:17
@the-maldridge
Copy link
Member

Closed by b766fcd

@motorto motorto deleted the loudagaing branch November 22, 2020 10:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants