Add Write from Stylus Labs #24555

cat-marin · 2020-08-30T19:58:05Z

Starting college and thought it might be easier to set up new systems with Write in void-packages.

fosslinux · 2020-08-31T01:34:02Z

Should install to /usr.

cat-marin · 2020-08-31T02:05:59Z

Should install to /usr.

It does install to /usr. Or are you talking about $package_location?

fosslinux · 2020-08-31T02:50:50Z

Yeah $package_location, everything is being copied to /opt, packages should not touch /opt; everything should be installed directly to /usr only.

cat-marin · 2020-08-31T03:29:30Z

Yeah $package_location, everything is being copied to /opt, packages should not touch /opt; everything should be installed directly to /usr only.

I've moved it to /usr/lib/$pkgname. I can't imagine this would be an issue as the discord package does the same thing, am I correct in assuming this?

fosslinux

Thanks for that change.

Take a look here, there's a few outstanding issues, https://travis-ci.org/github/void-linux/void-packages/jobs/722610669.

Look at how discord does the EULA download. You should do something similar here with a vlicense; generally this is required with 99% of these types of programs and is good practice anyway.

Oh, and also squash all your commits under New package: write-styluslabs-3.0.0..

fosslinux · 2020-08-31T03:55:52Z

srcpkgs/write-styluslabs/template

@@ -0,0 +1,32 @@
+# Template file for 'Write'


Should be identical to the pkgname.

fosslinux · 2020-08-31T03:56:54Z

srcpkgs/write-styluslabs/template

+archs="x86_64"
+wrksrc="Write"
+depends="SDL2"
+short_desc="A word processor for handwriting"


Remove A, see xlint error

Update Write.desktop to reflect proper binary location Install to /usr instead of /opt Remove A, change template comment

cat-marin · 2020-08-31T04:27:51Z

My bad on the last one, I'm not well versed in git. Working on the squash, heh. Also, I cannot find any kind of license on their site. They have a github for other libraries used in the program but there is no kind of EULA that I can find on the project website.

Update Write.desktop to reflect proper binary location Install to /usr instead of /opt Remove A, change template comment

fosslinux · 2020-08-31T06:15:03Z

Hm, seems to be the case... not 100% sure what to do here. git rebase -i HEAD~20 (or ~however-many-commits-back) should help you.

cat-marin · 2020-08-31T06:23:48Z

Have I not done it already? I did git rebase. Or should it also change the PR name?

fosslinux · 2020-08-31T06:24:58Z

No, it has nothing to do with the PR name. git rebase on its own will do nothing. Look here, https://github.com/void-linux/void-packages/pull/24555/commits there are still 8 commits in this PR.

ahesford · 2020-09-02T17:00:03Z

What you need to do is, assuming the void-linux/void-packages remote is called upstream in your repo,

git pull --rebase upstream master
git rebase -i upstream/master

If you are working from your fork alone, you should first do

git remote add upstream https://github.com/void-linux/void-packages

Then, in the editor that git rebase -i opens up, change the pick on the first line to r for reword, and change the pick on every subsequent line to f for fixup. When you save and quit your editor, it will open a new editor and allow you to set a message for the first commit; give this the expected "new package" message. Every other commit in your branch will be folded into the first one, so you will reduce this PR to a single commit with the correct message.

ahesford

As xlint reports, indent function bodies with a tab rather than several spaces.

The unversioned distfiles link militates against inclusion of this template in its current form, and the unknown license militates strongly against inclusion of this template in its current form. Also, the Write tarball includes an executable, two fonts, a desktop shortcut and an icon. I have a suspicion that this executable runs just as well from a local subdirectory of $HOME as it does from /usr/lib/write-styluslabs. This package appears to fall short of the quality requirements.

If you disagree, please make a case for why an exception should be made.

ahesford · 2020-09-02T23:44:58Z

srcpkgs/write-styluslabs/template

+maintainer="Cat Marin <me@jmarin.xyz>"
+license="custom:Proprietary"
+homepage="http://www.styluslabs.com/"
+distfiles="http://www.styluslabs.com/write/write-latest.tar.gz"


The distfiles URL is problematic because there is no fixed versioning. Whenever Stylus Labs releases a new version, that link will break the package, so things like package revbumps or local building become impossible. I suggest you try to find a versioned download, or else reach out to Stylus Labs about providing versioned downloads.

As far as I can tell that's how they release packages. I actually tried doing it with a variable and xbps-src doesn't accept version=latest. Until they provide versioned downloads, I'm not sure how else to proceed.

They provides versioned tarball, they just don't show you, here is the link for 3.0.0 http://www.styluslabs.com/write/write300.tar.gz

They provides versioned tarball, they just don't show you, here is the link for 3.0.0 http://www.styluslabs.com/write/write300.tar.gz

Yep! Saw that in their response to me email. However they still don't have a license available, which as I understand is necessary in order to proceed. In any case, judging by how many changes I needed to make (and quality concerns of my template) I'm in no way ready to take on maintaining a package. I'll look more into the documentation and other package templates before I do anything else.

Nah, packages in void aren't that hard. TBH, it's really just that you chose a slightly problematic package to start on :)

ahesford · 2020-09-02T23:49:32Z

srcpkgs/write-styluslabs/template

+depends="SDL2"
+short_desc="Word processor for handwriting"
+maintainer="Cat Marin <me@jmarin.xyz>"
+license="custom:Proprietary"


As the xlint CI test shows, a proprietary license declaration requires use of vlicense in do_install or post_install to copy the license text into the package. As it stands, I see no license terms attached to this software. You should identify the license terms and be able to fetch the license text from somewhere so we know what terms govern the software.

I'm currently in the process of contacting Stylus Labs on how they'd like me to proceed here, I'll update my PR when I know.

If they don't make versioned releases. it's unlikely to be accepted as a package here.

I'm not sure how well it fits under quality requirements either.

If they don't make versioned releases. it's unlikely to be accepted as a package here.

I've sent them an email regarding the issues on their end (including the license), I'll be closing my pull request until they respond/provide versioned downloads and a license.

http://www.styluslabs.com/write/write300.tar.gz

cat-marin · 2020-09-03T20:11:59Z

Closing

sgn · 2020-09-05T00:59:06Z

On 2020-09-04 13:39:43-0700, cat-marin ***@***.***> wrote: @cat-marin commented on this pull request. > @@ -0,0 +1,32 @@ +# Template file for 'write-styluslabs' +pkgname=write-styluslabs +version=3.0.0 +revision=1 +archs="x86_64" +wrksrc="Write" +depends="SDL2" +short_desc="Word processor for handwriting" +maintainer="Cat Marin ***@***.***>" +license="custom:Proprietary" +homepage="http://www.styluslabs.com/" +distfiles="http://www.styluslabs.com/write/write-latest.tar.gz" > They provides versioned tarball, they just don't show you, here is > the link for 3.0.0 http://www.styluslabs.com/write/write300.tar.gz Yep! Saw that in their response to me email. However they still don't have a license available, which as I understand is necessary in order to proceed.

The EULA is available at http://www.styluslabs.com/write/eula.docx Either ship the docx file, or use docx2txt to convert to plain text file

cat-marin · 2020-09-05T04:36:03Z

On 2020-09-04 13:39:43-0700, cat-marin notifications@github.com wrote:

@cat-marin commented on this pull request.

@@ -0,0 +1,32 @@
+# Template file for 'write-styluslabs'
+pkgname=write-styluslabs
+version=3.0.0
+revision=1
+archs="x86_64"
+wrksrc="Write"
+depends="SDL2"
+short_desc="Word processor for handwriting"
+maintainer="Cat Marin me@jmarin.xyz"
+license="custom:Proprietary"
+homepage="http://www.styluslabs.com/"
+distfiles="http://www.styluslabs.com/write/write-latest.tar.gz"

They provides versioned tarball, they just don't show you, here is
the link for 3.0.0 http://www.styluslabs.com/write/write300.tar.gz

Yep! Saw that in their response to me email. However they still
don't have a license available, which as I understand is necessary
in order to proceed.

The EULA is available at http://www.styluslabs.com/write/eula.docx
Either ship the docx file, or use docx2txt to convert to plain text
file

Interesting, was this added after I just emailed asking them to add it? Because when they responded they just said there wasn't really a license.

cat-marin added 2 commits August 30, 2020 15:56

Add Write from Stylus Labs

ea84bca

Update Write.desktop to reflect proper binary location

f3c71f6

Install to /usr instead of /opt

7473511

fosslinux suggested changes Aug 31, 2020

View reviewed changes

cat-marin added 3 commits August 31, 2020 00:22

Remove A, change template comment

9f49c00

Add Write from Stylus Labs

826836a

Update Write.desktop to reflect proper binary location Install to /usr instead of /opt Remove A, change template comment

Merge branch 'master' of github.com:cat-marin/void-packages into master

cfad335

cat-marin added 2 commits August 31, 2020 00:28

New package: write-styluslabs-3.0.0.

38ff902

Update Write.desktop to reflect proper binary location Install to /usr instead of /opt Remove A, change template comment

Merge branch 'master' of github.com:cat-marin/void-packages into master

5c9dc98

ahesford requested changes Sep 2, 2020

View reviewed changes

cat-marin closed this Sep 3, 2020

github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Write from Stylus Labs #24555

Add Write from Stylus Labs #24555

cat-marin commented Aug 30, 2020

fosslinux commented Aug 31, 2020

cat-marin commented Aug 31, 2020

fosslinux commented Aug 31, 2020

cat-marin commented Aug 31, 2020

fosslinux left a comment •

edited

Loading

fosslinux Aug 31, 2020

fosslinux Aug 31, 2020

cat-marin commented Aug 31, 2020

fosslinux commented Aug 31, 2020

cat-marin commented Aug 31, 2020

fosslinux commented Aug 31, 2020

ahesford commented Sep 2, 2020 •

edited

Loading

ahesford left a comment

ahesford Sep 2, 2020

cat-marin Sep 3, 2020

sgn Sep 4, 2020

cat-marin Sep 4, 2020

fosslinux Sep 5, 2020

ahesford Sep 2, 2020

cat-marin Sep 3, 2020

ericonr Sep 3, 2020

ericonr Sep 3, 2020

cat-marin Sep 3, 2020

sgn Sep 4, 2020

cat-marin commented Sep 3, 2020

sgn commented Sep 5, 2020 via email

cat-marin commented Sep 5, 2020

Add Write from Stylus Labs #24555

Add Write from Stylus Labs #24555

Conversation

cat-marin commented Aug 30, 2020

fosslinux commented Aug 31, 2020

cat-marin commented Aug 31, 2020

fosslinux commented Aug 31, 2020

cat-marin commented Aug 31, 2020

fosslinux left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cat-marin commented Aug 31, 2020

fosslinux commented Aug 31, 2020

cat-marin commented Aug 31, 2020

fosslinux commented Aug 31, 2020

ahesford commented Sep 2, 2020 • edited Loading

ahesford left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cat-marin commented Sep 3, 2020

sgn commented Sep 5, 2020 via email

cat-marin commented Sep 5, 2020

fosslinux left a comment •

edited

Loading

ahesford commented Sep 2, 2020 •

edited

Loading