Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Write from Stylus Labs #24555

Closed
wants to merge 8 commits into from
Closed

Add Write from Stylus Labs #24555

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ea84bca
Add Write from Stylus Labs
cat-marin Aug 30, 2020
f3c71f6
Update Write.desktop to reflect proper binary location
cat-marin Aug 30, 2020
7473511
Install to /usr instead of /opt
Aug 31, 2020
9f49c00
Remove A, change template comment
cat-marin Aug 31, 2020
826836a
Add Write from Stylus Labs
cat-marin Aug 30, 2020
cfad335
Merge branch 'master' of github.com:cat-marin/void-packages into master
cat-marin Aug 31, 2020
38ff902
New package: write-styluslabs-3.0.0.
cat-marin Aug 30, 2020
5c9dc98
Merge branch 'master' of github.com:cat-marin/void-packages into master
cat-marin Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions srcpkgs/write-styluslabs/template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Template file for 'write-styluslabs'
pkgname=write-styluslabs
version=3.0.0
revision=1
archs="x86_64"
wrksrc="Write"
depends="SDL2"
short_desc="Word processor for handwriting"
maintainer="Cat Marin <me@jmarin.xyz>"
license="custom:Proprietary"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the xlint CI test shows, a proprietary license declaration requires use of vlicense in do_install or post_install to copy the license text into the package. As it stands, I see no license terms attached to this software. You should identify the license terms and be able to fetch the license text from somewhere so we know what terms govern the software.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently in the process of contacting Stylus Labs on how they'd like me to proceed here, I'll update my PR when I know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they don't make versioned releases. it's unlikely to be accepted as a package here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how well it fits under quality requirements either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they don't make versioned releases. it's unlikely to be accepted as a package here.

I've sent them an email regarding the issues on their end (including the license), I'll be closing my pull request until they respond/provide versioned downloads and a license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.styluslabs.com/write/write300.tar.gz

homepage="http://www.styluslabs.com/"
distfiles="http://www.styluslabs.com/write/write-latest.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distfiles URL is problematic because there is no fixed versioning. Whenever Stylus Labs releases a new version, that link will break the package, so things like package revbumps or local building become impossible. I suggest you try to find a versioned download, or else reach out to Stylus Labs about providing versioned downloads.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell that's how they release packages. I actually tried doing it with a variable and xbps-src doesn't accept version=latest. Until they provide versioned downloads, I'm not sure how else to proceed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They provides versioned tarball, they just don't show you, here is the link for 3.0.0 http://www.styluslabs.com/write/write300.tar.gz

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They provides versioned tarball, they just don't show you, here is the link for 3.0.0 http://www.styluslabs.com/write/write300.tar.gz

Yep! Saw that in their response to me email. However they still don't have a license available, which as I understand is necessary in order to proceed. In any case, judging by how many changes I needed to make (and quality concerns of my template) I'm in no way ready to take on maintaining a package. I'll look more into the documentation and other package templates before I do anything else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, packages in void aren't that hard. TBH, it's really just that you chose a slightly problematic package to start on :)

checksum="ec7c8a59f453574aa272d859e4c926eab48122d4965644871bf7cbe3d4703c40"
repository=nonfree
restricted=yes

do_install() {
local package_location="usr/lib/$pkgname" item
vmkdir usr/share/pixmaps
vcopy Write144x144.png /usr/share/pixmaps
vmkdir usr/share/applications
sed -i "s|/opt/Write/Write|/usr/lib/$pkgname/Write|g" Write.desktop
vcopy Write.desktop /usr/share/applications
vmkdir ${package_location}
chmod +x Write
for item in Write DroidSansFallback.ttf Intro.svg Roboto-Regular.ttf; do
vcopy "Write" "${package_location}"
vcopy "${item}" "${package_location}"
done
vmkdir usr/bin
ln -sfr $DESTDIR/${package_location}/Write $DESTDIR/usr/bin/write-styluslabs
}