Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build libva with glx (remove libva-glx) #25674

Closed
wants to merge 8 commits into from

Conversation

st3r4g
Copy link
Contributor

@st3r4g st3r4g commented Oct 17, 2020

Since we have libglvnd now, it should be possible to build libva with glx support without introducing build cycles.
Untested for now
Hmm maybe the transition can be done by replace= and removing libva-glx completely

@ericonr
Copy link
Member

ericonr commented Oct 17, 2020

Nice! It seems to have built fine, at least.

@st3r4g
Copy link
Contributor Author

st3r4g commented Oct 19, 2020

I have tested that the replacement of libva-glx with libva happens correctly. Couldn't test bomi because it seems to have a problem on its own (some missing stuff for the ui, results in a black window), I'll open an issue for that. But libva initializes fine as seen by the terminal log.

Now I'm thinking that QMPlay2, mpv and qtav don't need to be rebuilt since nothing changes for the binpkg, right? (because they weren't actually linking to libva-glx before)

@travankor
Copy link
Contributor

Now I'm thinking that QMPlay2, mpv and qtav don't need to be rebuilt since nothing changes for the binpkg, right? (because they weren't actually linking to libva-glx before)

Yes, I think that's correct.

@st3r4g st3r4g changed the title [WIP] Build libva with glx (remove libva-glx) Build libva with glx (remove libva-glx) Oct 19, 2020
@st3r4g
Copy link
Contributor Author

st3r4g commented Oct 19, 2020

ready for review

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this introduces no dependency cycles. However, you need libva-glx and libva-glx-devel transitional packages to pull in the new libva and libva-devel, respectively. While XBPS will recognize the replaces directive if a dependant is updated and requires the new merged package, it will not recognize the replacement path on its own. Transitional packages will force this.

@st3r4g
Copy link
Contributor Author

st3r4g commented Oct 21, 2020

However, you need libva-glx and libva-glx-devel transitional packages to pull in the new libva and libva-devel, respectively. While XBPS will recognize the replaces directive if a dependant is updated and requires the new merged package, it will not recognize the replacement path on its own. Transitional packages will force this.

But here libva-glx depends on libva already (and same for -devel) so the replacement will always happen.

@ericonr
Copy link
Member

ericonr commented Oct 21, 2020

@st3r4g could perhaps add this explanation to the commit message?

@ahesford
Copy link
Member

OK, that makes sense.

@st3r4g
Copy link
Contributor Author

st3r4g commented Oct 22, 2020

@st3r4g could perhaps add this explanation to the commit message?

done

@ericonr
Copy link
Member

ericonr commented Nov 1, 2020

Pending on confirmation from #18712

@ericonr ericonr changed the title Build libva with glx (remove libva-glx) [WIP] Build libva with glx (remove libva-glx) Nov 2, 2020
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 21, 2022
@github-actions github-actions bot closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants