-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Build libva with glx (remove libva-glx) #25674
Conversation
f1723d2
to
f38da85
Compare
Nice! It seems to have built fine, at least. |
I have tested that the replacement of Now I'm thinking that |
Yes, I think that's correct. |
f38da85
to
333a7d7
Compare
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this introduces no dependency cycles. However, you need libva-glx
and libva-glx-devel
transitional packages to pull in the new libva
and libva-devel
, respectively. While XBPS will recognize the replaces
directive if a dependant is updated and requires the new merged package, it will not recognize the replacement path on its own. Transitional packages will force this.
But here |
@st3r4g could perhaps add this explanation to the commit message? |
OK, that makes sense. |
libva-glx depends on libva already (and same for -devel) so the replacement will always happen without the need for a transitional package.
333a7d7
to
285b99f
Compare
done |
Pending on confirmation from #18712 |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Since we have
libglvnd
now, it should be possible to build libva with glx support without introducing build cycles.Untested for now
Hmm maybe the transition can be done by replace= and removing libva-glx completely