Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: notcurses and growlight #26292

Merged
merged 4 commits into from
Nov 21, 2020

Conversation

mobinmob
Copy link
Contributor

No description provided.

@mobinmob
Copy link
Contributor Author

mobinmob commented Nov 11, 2020

  • notcurses-doc is packaged seperately as it is provided in a seperate tarball. That is nice, because we can have html docs and man pages without using pandoc during the build.
  • notcurses uses doctest for testing, which is a single-header library. I do not think it makes sense to package it...
  • notcurses also uses qrcodegen - it is in the repo but the template builds and installs only the C++ version, not the C one. I am not sure how to handle this.

Regardless of the above, I have tested both growlight and notcurses on x86_64.

@mobinmob mobinmob changed the title [WIP] New packages: notcurses and growlight New packages: notcurses and growlight Nov 11, 2020
@mobinmob
Copy link
Contributor Author

  • Added some runtime dependencies to growlight.
  • Both programms build succesfully for armv7, aarch64, aarch64-musl.

@mobinmob
Copy link
Contributor Author

mobinmob commented Nov 11, 2020

  • Also build succesfully for amv7-musl, armv6l-musl, armv6l, i686, x86_64-musl.

srcpkgs/growlight/template Outdated Show resolved Hide resolved
@mobinmob
Copy link
Contributor Author

  • Added C libs in the qrcodegen, @pullmoll please check.

@mobinmob
Copy link
Contributor Author

  • Added doctest.
  • Removed notcurses-doc - the manpages are build with pandoc.

@the-maldridge the-maldridge merged commit b143cc7 into void-linux:master Nov 21, 2020
@mobinmob mobinmob deleted the notcurses+growlight branch November 22, 2020 09:36
@q66
Copy link
Contributor

q66 commented Nov 24, 2020

8690cd6
f52b465

avoid hard-depending on pandoc in the future, it's unnecessary and breaks any platform that doesn't have a haskell toolchain built

@mobinmob
Copy link
Contributor Author

mobinmob commented Nov 24, 2020

8690cd6
f52b465

avoid hard-depending on pandoc in the future, it's unnecessary and breaks any platform that doesn't have a haskell toolchain built

Τhanks. I pondered what to do about the docs:
#26292 (comment)

@q66
Copy link
Contributor

q66 commented Nov 24, 2020

it doesn't matter it's host-only, that still means you're breaking things for anyone who wants to e.g. build on arm natively, etc

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants