[WIP] hooks/shlib-provides: verify that shlibs in shlib-provides and common/shlibs match. #26547
Conversation
ericonr
changed the title
|
I think what this also needs to check is that the file exists in the package. |
common/shlibs have sane values. - Check if shlib-provides and common/shlibs agree - Check if file for shlib is actually present in final package
|
How do I get the current package's name from inside a hook? |
|
I haven't looked at the implementation details, but this is a great idea. Failing when |
| msg_red "file for shlib '$1' isn't in ${pkgname}\n" | ||
| fi | ||
| fi | ||
| shift 2 |
There was a problem hiding this comment.
There is third optional column in shlibs. 99-pkglint.sh use grep shlibs -e ... | while read conflictFile conflictPkg ignore; do ... to handle that. And then interpretation of third column is needed for glibc.
| while [ $# -gt 0 ] | ||
| do | ||
| if [ "$($XBPS_UHELPER_CMD getpkgname "$2")" = ${pkgname} ]; then | ||
| if [[ "${pkgshlibs}" != *"$1"* ]]; then |
There was a problem hiding this comment.
This need be a loop over shlib-provides lines to avoid matching substrings.
| @@ -53,4 +86,6 @@ hook() { | |||
| collect_sonames ${PKGDESTDIR} | |||
| # 32bit pkg | |||
| collect_sonames ${_destdir32} | |||
|
|
|||
| verify_sonames ${PKGDESTDIR} || return 1 | |||
There was a problem hiding this comment.
Do we want it to run when noshlibprovides is set?
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
common/shlibs match.