Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-saml2: update to 6.4.1. #27050

Closed
wants to merge 1 commit into from
Closed

python3-saml2: update to 6.4.1. #27050

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Dec 9, 2020

This fixes byte-compiling upon install

@ndowens ndowens marked this pull request as draft December 9, 2020 16:02
@ericonr
Copy link
Member

ericonr commented Dec 9, 2020

Oops, it hadn't been merged yet #26901

@ndowens ndowens marked this pull request as ready for review December 9, 2020 21:19
@ahesford ahesford closed this in e285453 Dec 10, 2020
@ahesford
Copy link
Member

tox is generally disfavored because it doesn't actually test against the contents of the package and the Void-packaged dependencies. It creates a virtualenv and populates it with pip, then tests that.

For pytest, you need to make sure all dependencies are available, plus a couple of extras just for testing. We don't package a couple of these, so you have to ignore tests that require thigns we don't provide. You also need, in this case, to set PYTHONPATH=src because the project package are inside this subdirectory (you could also use build/lib* to get the staged package created by setuptools).

See e285453 for more information.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants