-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vale update, style packages #27201
vale update, style packages #27201
Conversation
i think |
@SolitudeSF you were right, thanks |
Am I correct in assuming that |
@ericonr I think so, but even if you install example config if you want to try it:
|
Might be nice to make a request for it :) at least so the user doesn't have to specify |
Also, vale output shows
maybe there is a build time flag to set this appropriately? |
https://github.com/errata-ai/vale/blob/430f6c8b4e6c00e2e50c0c0f4a3475f314db17ee/Makefile#L4 this is probably what you want. There are other templates doing similar things as well. |
@ericonr thanks, fixed the version
hmm, I do not think this is the correct solution anymore. If the user doesn't specify a config, no style should be used. I don't think all styles available in the system should be used. I will suggest to them a default StylesPath, but the user will still have to specify BasedOnStyles. |
Indeed, at least this. |
why don't the style packages depend on vale? now you can build the styles for targets which don't have vale at all (because they don't have go) |
I didn't consider in this case that vale itself wouldn't be available on all platforms. I guess I was thinking of packages like hunspell and aspell dicts, which don't depend on their respective tools. It probably makes more sense for them since they can be used by other packages, which isn't the case for the style packages. I think we can add a dependency, perhaps... @paper42 what do you think? |
The styles are "vale compatible" which means there can be other tools using them, but I don't know about any. |
well, if the styles don't necessarily require the original thing, it's probably okay to just leave it |
ping @SolitudeSF
it does not build without this line, but I didn't find a better way to do it