[WIP] octave: update to 6.2.0. #27775
Conversation
|
Error from test suite: |
|
I don't know if we need all of them passing cleanly, octave is rather big and complicated. |
| # on all others. | ||
| case "$XBPS_TARGET_MACHINE" in | ||
| # List of supported architectures copied from openblas. | ||
| armv[67]*|aarch64*|i686*|x86_64*|ppc64*) |
There was a problem hiding this comment.
why add this list now?after taking a look at openblas/template, openblas is available for ppc and armv5 as well and they aren't listed (meaning: all archs Void provides binary packages for have openblas available).
you might as well be better off just marking mips*) to use regular blas to match this, as done in openblas/template.
may i ask which arch you had in mind in specific which caused any trouble here?
There was a problem hiding this comment.
openblas has:
case "${XBPS_TARGET_MACHINE}" in
armv5*) make_build_args+=" TARGET=ARMV5" ;;
armv6*) make_build_args+=" TARGET=ARMV6" ;;
armv7*) make_build_args+=" TARGET=ARMV7" ;;
aarch64*) make_build_args+=" TARGET=ARMV8 DYNAMIC_ARCH=1" ;;
i686*) make_build_args+=" BINARY=32 TARGET=GENERIC DYNAMIC_ARCH=1" ;;
x86_64*) make_build_args+=" BINARY=64 TARGET=GENERIC DYNAMIC_ARCH=1" ;;
ppc64le*) make_build_args+=" TARGET=POWER8 DYNAMIC_ARCH=1" ;;
ppc64*) make_build_args+=" TARGET=PPC970MP" ;; # dynamic arch broken for <power6
ppc*) make_build_args+=" TARGET=PPCG4" ;;
mips*) broken="Not supported" ;;
*) broken="Add your CPU" ;;
esac
which would mean that eventual riscv target would be broken by default, for example, and would block octave from being built instead of building it with lapack. I think listing where it's known to work is a bit more correct.
srcpkgs/octave/template
Outdated
| makedepends="pcre-devel openblas-devel readline-devel libSM-devel libltdl-devel | ||
| lcms2-devel glpk-devel" | ||
| depends="$(vopt_if gui qt5-plugin-sqlite) texinfo" | ||
| depends="$(vopt_if gui qt5-plugin-sqlite) texinfo texlive-dvi tar" |
There was a problem hiding this comment.
what for is the runtime dependency on tar? I'm inclined to not add it to depends as tar is part of base-system already (no other package explicitly depends on tar, though many might need it)
There was a problem hiding this comment.
Assuming it's necessary only for building packages, I don't think it's necessary to have it in depends. You still need gcc-fortran and other dependencies to build them.
There was a problem hiding this comment.
Sorry for dropping the ball on this. I'm currently too busy to work further on this. Anyone else feel free to pick up where I left off.
|
ping @diogoleal |
- add support for targets without proper openblas support - add changelog for the 6.x release series - fix gui deps - adding 'texlive-dvi' and 'tar' to depends to make building external packages easier was considered, but ultimately dismissed; since they aren't enough to actually build packages, they would increase dependency count for little gain Co-authored-by: Érico Nogueira <erico.erc@gmail.com>
No description provided.