[WIP] Cinnamon 4.8 #28035
Merged
[WIP] Cinnamon 4.8 #28035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
force-pushed
the
cinna
branch
2 times, most recently
from
9e56845
to
b52ce03
Compare
This was referenced Jan 19, 2021
Thank you for taking over the cinnamon update! I am swamped with work (unexpectedly) today. |
|
I'm seeing if I can fix #10650 before merging. |
|
Depends on linuxmint/cinnamon-screensaver#363 |
|
@sgn I will add a comment explaining that, thanks. IMO the libdir hook should also be fixed (in a different PR) |
The libdir changes to use /usr/lib{32,64} instead of /usr/lib broke
cross builds for some packages that use gir, due to issues with copying
over symlinks. Since we haven't managed to track down the root cause for
the installation path, a symlink is a clean enough temporary fix. This
follows the style of the 00-libdir hooks.
Since pre-install runs for the main package and then each subpackage, it
should use PKGDESTDIR (not DESTDIR), which also enables a subpackage
that installs files during pkg_install to work cleanly.
As far as I can see, the previous hook was quite flawed. Since it was a
pre-install hook, the check for a directory would happen *before*
package installation (so nothing would happen). The only reason it did
anything was because it also ran as a step before a subpackage's
pkg_install (most GIR packages have a -devel subpackage), but used
DESTDIR instead of PKGDESTDIR, so it checked and affected the contents
of the main package. Then when the subpackage's pkg_install ran, the
files would have already been copied to the correct folders.
Closes void-linux#27437
Fix homepage.
Fix homepage.
Fix homepage.
Fix homepage.
Fix homepage.
Includes changes by @ndowens. Closes: void-linux#26965 [via git-merge-pr]
Fix homepage.
Fix homepage.
Include changes by @ndowens. Also by ericonr: - fix names in .desktop file to differentiate between them - fix homepage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26965
Have the results of the proposed changes been tested?
@mobinmob I have yet to search for new releases, but if you know of any I'm missing, please let me know.