Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass: update to 1.12.0. #28202

Merged
merged 1 commit into from
Feb 11, 2021
Merged

gopass: update to 1.12.0. #28202

merged 1 commit into from
Feb 11, 2021

Conversation

dshynkev
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@dshynkev
Copy link
Contributor Author

dshynkev commented Jan 24, 2021

One thing of note: this version changed the way the gpg binary is selected. They assume gpg points to the version of GPG the user uses, but on Void it points to GPG v1, which is probably not what most use.

One must export GOPASS_GPG_BINARY=$(which gpg2) for it to keep working with GPG v2.

Should I note this in a post-install message?

@ericonr
Copy link
Member

ericonr commented Jan 24, 2021

I'd use /usr/bin/gpg2 directly instead of which.

You could also open an RFC for dropping old GPG, if you think it's feasible.

@dshynkev
Copy link
Contributor Author

It should be possible. A few of current gnupg revdeps definitely support gnupg2.

I'll file an RFC, but perhaps for now a post-install message is best?
It might take a while to phase out v1 if at least one of its revdeps really requires it.

I could also patch gopass if that's more appropriate. Sorry, not sure about the Void packaging etiquette.

@dshynkev
Copy link
Contributor Author

I've tentatively added a message.

@ericonr
Copy link
Member

ericonr commented Jan 25, 2021

It might take a while to phase out v1 if at least one of its revdeps really requires it.

Fair enough :)

Ideally, we want to make the package with as little friction as possible. If Void still defaulting to gnupg 1 makes it an issue (assuming most users do actually use gnupg2 instead), we can consider patching, IMO. I'm tagging @fnogcps so they can leave their thoughts here.

@ahesford
Copy link
Member

Upstream is doing this wrong. GPG2 provides gpgconf to provide a machine-readable way to discover the path to the gpg binary. If gpgconf is available, you query that for the full path to the gpg executable, which in Void returns /usr/bin/gpg2. If gpgconf is not available, then you fall back to looking for gpg in the path.

@ericonr
Copy link
Member

ericonr commented Jan 25, 2021

@dshynkev see #28217 :)

@ericonr ericonr mentioned this pull request Jan 25, 2021
3 tasks
srcpkgs/gopass/template Outdated Show resolved Hide resolved
@ahesford
Copy link
Member

ahesford commented Jan 27, 2021

FYI, upstream is considering properly looking for the gpg2 binary. Might want to keep an eye on that PR and, if it's accepted, backport the patch for this release if they don't cut a new release.

@dshynkev
Copy link
Contributor Author

Thanks for reporting it to them!

@ahesford
Copy link
Member

ahesford commented Feb 2, 2021

gopasspw/gopass@2b2c605

@dshynkev dshynkev changed the title gopass: update to 1.11.0. gopass: update to 1.12.0. Feb 11, 2021
@dshynkev
Copy link
Contributor Author

The next version got tagged. Didn't want to carry a non-trivial patch (just that commit alone didn't work) when release was imminent, and so finally we're here. Sorry about the delay!

@ericonr ericonr merged commit 5bb3316 into void-linux:master Feb 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants