Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gpgconf(1) to locate the gpg binary #1758

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

dominikschulz
Copy link
Member

Attempt to use gpgconf(1) for locating the path to the GPG binary.

Fixes #1757

RELEASE_NOTES=[ENHANCEMENT] Use gpgconf to the the gpg binary

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

@dominikschulz dominikschulz added the gpg GPG related label Jan 25, 2021
@dominikschulz dominikschulz added this to the 1.12.0 milestone Jan 25, 2021
AnomalRoil
AnomalRoil previously approved these changes Feb 1, 2021
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to also use gpgconf to get the pinentry binary, no?

return "pinentry"

It might allow us to remove the special case for Darwin:

return "pinentry-mac"

internal/backend/crypto/gpg/cli/binary_others.go Outdated Show resolved Hide resolved
AnomalRoil
AnomalRoil previously approved these changes Feb 2, 2021
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/backend/crypto/gpg/cli/binary_others.go Outdated Show resolved Hide resolved
Attempt to use gpgconf(1) for locating the path to the GPG binary.

Fixes gopasspw#1757

RELEASE_NOTES=[ENHANCEMENT] Use gpgconf to the the gpg binary

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dshynkev
Copy link

dshynkev commented Feb 2, 2021

Thanks for implementing this! Is there any chance 1.11.1 containing this commit will get tagged soon? Just asking to know whether to patch 1.11.0 or wait a bit.

@dominikschulz
Copy link
Member Author

I guess we're almost ready for 1.11.1.
One more PR waiting to get in and if no blockers show up we could tag it anytime.

@viq viq mentioned this pull request Oct 4, 2021
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Attempt to use gpgconf(1) for locating the path to the GPG binary.

Fixes gopasspw#1757

RELEASE_NOTES=[ENHANCEMENT] Use gpgconf to the the gpg binary

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpg GPG related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching path for gpg does not respect gnupg/gnupg2 side-by-side installation
3 participants