-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gpgconf(1) to locate the gpg binary #1758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to also use gpgconf to get the pinentry
binary, no?
return "pinentry" |
It might allow us to remove the special case for Darwin:
return "pinentry-mac" |
1fdf159
to
944e160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Attempt to use gpgconf(1) for locating the path to the GPG binary. Fixes gopasspw#1757 RELEASE_NOTES=[ENHANCEMENT] Use gpgconf to the the gpg binary Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
944e160
to
e333108
Compare
Thanks for implementing this! Is there any chance 1.11.1 containing this commit will get tagged soon? Just asking to know whether to patch 1.11.0 or wait a bit. |
I guess we're almost ready for 1.11.1. |
Attempt to use gpgconf(1) for locating the path to the GPG binary. Fixes gopasspw#1757 RELEASE_NOTES=[ENHANCEMENT] Use gpgconf to the the gpg binary Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Attempt to use gpgconf(1) for locating the path to the GPG binary.
Fixes #1757
RELEASE_NOTES=[ENHANCEMENT] Use gpgconf to the the gpg binary
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org