Add new package walk #28273
Add new package walk #28273
Conversation
srcpkgs/walk/template
Outdated
| build_style="gnu-makefile" | ||
| wrksrc="${pkgname}-${_commit}" | ||
| short_desc="walk and sor utility, collectively replacing find" | ||
| maintainer="orphaned" |
There was a problem hiding this comment.
Why is this already orphaned?
There was a problem hiding this comment.
Do you want maintainership?
There was a problem hiding this comment.
Generally if you make the PR to add it, you be willing to maintain it.
srcpkgs/walk/template
Outdated
| _commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d | ||
| build_style="gnu-makefile" | ||
| wrksrc="${pkgname}-${_commit}" | ||
| short_desc="walk and sor utility, collectively replacing find" |
There was a problem hiding this comment.
Rephrased since the tool name is lower case
srcpkgs/walk/template
Outdated
| } | ||
|
|
||
| do_install() { | ||
| vinstall sor 0755 usr/bin/ |
There was a problem hiding this comment.
Done, I had not run xlint at all before.
srcpkgs/walk/template
Outdated
| checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd | ||
|
|
||
| do_build() { | ||
| make |
There was a problem hiding this comment.
Is there an issue with the do_build provided by build_style=gnu-makefile
There was a problem hiding this comment.
Only that I did not know about it.
I misunderstood what you said, I tested with default do_build from gnu-makefile and removed the override.
| pkgname=walk | ||
| version=20190920 | ||
| revision=1 | ||
| _commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d |
There was a problem hiding this comment.
Consider opening an issue upstream to periodically tag actual releases?
There was a problem hiding this comment.
Upstream seemst to not have moved since 2019... Unless this is widely requested or similar, I don't fancy accepting something that doesn't have any official releases.
There was a problem hiding this comment.
I asked for that in google/walk#3
anddam
force-pushed
the
feature-new-package-walk
branch
from
75301a7
to
0ee693d
Compare
|
The commit message should also follow the convention of "New package: walk-20190920" |
Duly noted, just found the relevant part in |
anddam
force-pushed
the
feature-new-package-walk
branch
2 times, most recently
from
83e1131
to
ffdd27f
Compare
srcpkgs/walk/template
Outdated
| wrksrc="${pkgname}-${_commit}" | ||
| build_style="gnu-makefile" | ||
| short_desc="Two utilities collectively replacing find: walk and sor" | ||
| maintainer="Orphaned <orphaned@voidlinux.org>" |
There was a problem hiding this comment.
This is not the correct mail.
And given that this is a rather niche package, it should have a maintainer in order to be accepted.
There was a problem hiding this comment.
I took maintainership.
anddam
force-pushed
the
feature-new-package-walk
branch
from
ffdd27f
to
f9290b5
Compare
anddam
force-pushed
the
feature-new-package-walk
branch
from
f9290b5
to
a5744f9
Compare
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
General
Have the results of the proposed changes been tested?