-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new package walk #28273
Add new package walk #28273
Conversation
srcpkgs/walk/template
Outdated
build_style="gnu-makefile" | ||
wrksrc="${pkgname}-${_commit}" | ||
short_desc="walk and sor utility, collectively replacing find" | ||
maintainer="orphaned" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this already orphaned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want maintainership?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally if you make the PR to add it, you be willing to maintain it.
srcpkgs/walk/template
Outdated
_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d | ||
build_style="gnu-makefile" | ||
wrksrc="${pkgname}-${_commit}" | ||
short_desc="walk and sor utility, collectively replacing find" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize the beginning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased since the tool name is lower case
srcpkgs/walk/template
Outdated
} | ||
|
||
do_install() { | ||
vinstall sor 0755 usr/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vbin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I had not run xlint at all before.
srcpkgs/walk/template
Outdated
checksum=fce16683d757605a11284586794627a4352ec62718c59093a02f56b39896a1cd | ||
|
||
do_build() { | ||
make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue with the do_build
provided by build_style=gnu-makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only that I did not know about it.
I misunderstood what you said, I tested with default do_build
from gnu-makefile
and removed the override.
pkgname=walk | ||
version=20190920 | ||
revision=1 | ||
_commit=70f7a8c104acf109ae810a9b34eb8e8b92b4d27d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider opening an issue upstream to periodically tag actual releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream seemst to not have moved since 2019... Unless this is widely requested or similar, I don't fancy accepting something that doesn't have any official releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked for that in google/walk#3
75301a7
to
0ee693d
Compare
The commit message should also follow the convention of "New package: walk-20190920" |
Duly noted, just found the relevant part in |
83e1131
to
ffdd27f
Compare
srcpkgs/walk/template
Outdated
wrksrc="${pkgname}-${_commit}" | ||
build_style="gnu-makefile" | ||
short_desc="Two utilities collectively replacing find: walk and sor" | ||
maintainer="Orphaned <orphaned@voidlinux.org>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct mail.
And given that this is a rather niche package, it should have a maintainer in order to be accepted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took maintainership.
ffdd27f
to
f9290b5
Compare
f9290b5
to
a5744f9
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
General
Have the results of the proposed changes been tested?