Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-helper/qmake: disable rpath #28581

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

sgn
Copy link
Member

@sgn sgn commented Feb 8, 2021

@st3r4g Please test qjackctl.

@sgn sgn force-pushed the qmake-build-helper-disable-rpath branch from 327087c to 292c2ce Compare February 8, 2021 13:08
@st3r4g
Copy link
Contributor

st3r4g commented Feb 8, 2021

Could you update qjackctl to 0.9.1 here so we save a rebuild?

@ericonr
Copy link
Member

ericonr commented Feb 8, 2021

Ideally we should runtime test all of them... Otherwise some of them could be accidentally relying on rpath to work at all, and we wouldn't detect them.

@sgn
Copy link
Member Author

sgn commented Feb 8, 2021

Could you update qjackctl to 0.9.1 here so we save a rebuild?

Okey.

Ideally we should runtime test all of them... Otherwise some of them could be accidentally relying on rpath to work at all, and we wouldn't detect them.

Well, I don't use any of them, so my testing ability will be very limited.

@sgn
Copy link
Member Author

sgn commented Feb 8, 2021

Anyway, for a long time, the RPATH for cross-compiled stuff is $XBPS_CROSS_BASE/usr/lib and nothing breaks.

@st3r4g
Copy link
Contributor

st3r4g commented Feb 8, 2021

I confirm that this removes rpath from qjackctl, thus allowing it to be used with pipewire. Incidentally, current pipewire version has a bug that prevents qjackctl to start, but it's already fixed on master. I can PR a patch #28589

@sgn sgn force-pushed the qmake-build-helper-disable-rpath branch from 5932012 to 466153a Compare February 10, 2021 13:15
- create pseudo target for cross compile in order to not include host
  specific headers
- look for modules inside target
- ignore rpath
@sgn sgn force-pushed the qmake-build-helper-disable-rpath branch from 466153a to 78495ba Compare February 10, 2021 13:43
@sgn sgn merged commit 4ca3b08 into void-linux:master Feb 11, 2021
@sgn sgn deleted the qmake-build-helper-disable-rpath branch April 9, 2021 00:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants