Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipewire: apply qjackctl fix from master #28589

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

st3r4g
Copy link
Contributor

@st3r4g st3r4g commented Feb 8, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/696

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the commit to the top of the file. It's hard to tell what this does.

@st3r4g
Copy link
Contributor Author

st3r4g commented Feb 8, 2021

Can you add a link to the commit to the top of the file. It's hard to tell what this does.

Well, the commit hash is already in the filename, I though it was descriptive enough. Also it will be removed on next release. Should we just wait for next release?

@st3r4g st3r4g force-pushed the pipewire-0.3.21_2 branch 2 times, most recently from d5e2504 to 534a7d7 Compare February 8, 2021 15:57
@ericonr
Copy link
Member

ericonr commented Feb 8, 2021

Well, the commit hash is already in the filename, I though it was descriptive enough.

I somehow missed that, but the link is also easier to click and go directly to the explanation.

Re. Waiting for release, your choice. Pipewire is small enough IMO that either is ok. Unless a release is coming in the next few days, then I guess waiting is best.

@st3r4g
Copy link
Contributor Author

st3r4g commented Feb 8, 2021

Rerun CI because GitHub had problem earlier today.

Unless a release is coming in the next few days, then I guess waiting is best.

Releases are usually every 2 weeks.
But until the other PR (rpath removal) is merged qjackctl with pipewire is broken anyway.

@ericonr ericonr merged commit 6ae82c8 into void-linux:master Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants