Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud-client: update to 3.1.2, no shibboleth and webkit support, kwallet subpackage #28674

Merged
merged 1 commit into from
Feb 24, 2021
Merged

nextcloud-client: update to 3.1.2, no shibboleth and webkit support, kwallet subpackage #28674

merged 1 commit into from
Feb 24, 2021

Conversation

yopito
Copy link
Contributor

@yopito yopito commented Feb 11, 2021 •
edited
Loading

  • shibboleth is "highly deprecated" by upstream, will be removed in 3.2.
  • webkit support is currently ineffective and difficult to fix.
  • fix ~dolphin build options
  • Edit: add package nextcloud-client-kwallet to deal with nextcloud client no longer working #26774 .

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Feb 11, 2021 •
edited
Loading

I think we can avoid adding this to removed-packages for armv7l if we can move the arm builders to i686.

@paper42
Copy link
Member

paper42 commented Feb 11, 2021

@yopito could you fix the typo in the commit message? wekbit? 😉

@yopito
Copy link
Contributor Author

yopito commented Feb 11, 2021

@yopito could you fix the typo in the commit message? wekbit? wink

nice catch ! yes of course.

@yopito yopito changed the title [WIP] nextcloud-client: update to 3.1.2, remove shibboleth and wekbit support [WIP] nextcloud-client: update to 3.1.2, remove shibboleth and webkit support Feb 11, 2021
@yopito
Copy link
Contributor Author

yopito commented Feb 13, 2021

Added a new subpackage nextcloud-client-kwallet to deal with #26774 .
Added as a dedicated commit for now (to revert easily if not accepted), will squash if agreed.
@ericonr , @paper42 : thanks for your feeback on it.

@ericonr
Copy link
Member

ericonr commented Feb 13, 2021

I don't love this solution, but that's mainly because I don't like vendoring in desktop files. If you can generate the desktop file reliably with a sed on the original desktop file at build time, I'd rather have that.

Besides that, LGTM. Maybe make the INSTALL msg a README.voidlinux instead? Otherwise the message will always be there.

@yopito
Copy link
Contributor Author

yopito commented Feb 14, 2021

here it is. looks like this:
image

@yopito
Copy link
Contributor Author

yopito commented Feb 15, 2021

squashed commits, removed INSTALL.msg, add a README.voidlinux to new subpackage nextcloud-client-kwallet .

@yopito yopito changed the title [WIP] nextcloud-client: update to 3.1.2, remove shibboleth and webkit support nextcloud-client: update to 3.1.2, remove shibboleth and webkit support Feb 15, 2021
@yopito yopito mentioned this pull request Feb 15, 2021
Closed
@yopito yopito changed the title nextcloud-client: update to 3.1.2, remove shibboleth and webkit support nextcloud-client: update to 3.1.2, no shibboleth and webkit support, kwallet subpackage Feb 15, 2021
fosslinux
fosslinux suggested changes Feb 16, 2021
View reviewed changes
srcpkgs/nextcloud-client/files/kwallet/README.voidlinux Outdated
@@ -0,0 +1,3 @@
nextcloud-client-kwallet package provides a workaround to make nextcloud-client
uses kwallet as its credential storage via qtkeychain-qt5.
This is usefull when not using KDE as Desktop Environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usefull typo

@yopito
nextcloud-client: update to 3.1.2, no shibboleth and webkit support, …
adaa171 
…kwallet subpackage

* shibboleth is "highly deprecated" by upstream, will be removed in 3.2.
* webkit support is currently ineffective and difficult to fix.
* fix ~dolphin build options
* nextcloud-client-kwallet: dedicated package for kwallet as credential storage

Closes: void-linux#26774
@ericonr ericonr merged commit aa116ab into void-linux:master Feb 24, 2021
@q66
Copy link
Contributor

q66 commented Feb 24, 2021 •
edited
Loading

? why was the webengine option removed? the patch applies perfectly fine and doesn't need any rebasing (and irrelevant to webkit/shibboleth)

@yopito
Copy link
Contributor Author

yopito commented Feb 25, 2021

@q66: I don't remember exactly the details, but webkit support is completely useless according to my runtime tests.

@q66
Copy link
Contributor

q66 commented Feb 25, 2021

... the webkit stuff and the webengine removal patch are two completely different and separate things

webengine is used for login flow, which the patch disables, it does not use webkit for anything

@yopito
Copy link
Contributor Author

yopito commented Feb 25, 2021

I agree. but without the login flow, can this app be considered as usable ?
I don't see how to use it then.

@yopito yopito deleted the nextcloud.312 branch February 25, 2021 21:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fosslinux fosslinux fosslinux requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yopito @ericonr @paper42 @q66 @fosslinux