Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: python3-pytest-flake8-1.0.7 #28842

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Feb 18, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@folliehiyuki
Copy link
Contributor

Why not use the default do_check() from build style? It doesn't work?

@paper42 paper42 force-pushed the 0001-New-package-python3-pytest-flake8-1.0.7.patch branch from 714cd76 to 9029819 Compare February 18, 2021 15:37
@paper42
Copy link
Member Author

paper42 commented Feb 18, 2021

@folliehiyuki you were right, I forgot. Now I added PYTHONPATH, so I need it.

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this package isn't being pulled into checkdepends for other end-user packages, does it provide value on its own?

srcpkgs/python3-pytest-flake8/template Outdated Show resolved Hide resolved
@ericonr ericonr added the new-package This PR adds a new package label Feb 19, 2021
@paper42
Copy link
Member Author

paper42 commented Feb 19, 2021

If this package isn't being pulled into checkdepends for other end-user packages, does it provide value on its own?

no, but the tests depending on this package are patched out from at least python3-numpy-stl. Then, at least python3-pep517, python3-cairocffi and radicale have their tests disabled partially because of this missing package.

@paper42 paper42 force-pushed the 0001-New-package-python3-pytest-flake8-1.0.7.patch branch from 9029819 to 8c7314e Compare February 20, 2021 15:37
@ahesford
Copy link
Member

If adding this package is sufficient to make tests in python3-numpy-stl work without the pre_check patch, please drop that patch in this PR. No need to revbump.

@paper42 paper42 force-pushed the 0001-New-package-python3-pytest-flake8-1.0.7.patch branch from 8c7314e to 1d3d810 Compare March 2, 2021 19:53
@paper42
Copy link
Member Author

paper42 commented Mar 2, 2021

If adding this package is sufficient to make tests in python3-numpy-stl work without the pre_check patch, please drop that patch in this PR. No need to revbump.

@ahesford done

@paper42 paper42 requested a review from ahesford March 2, 2021 20:02
@ahesford ahesford merged commit 4e3219c into void-linux:master Mar 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
@paper42 paper42 deleted the 0001-New-package-python3-pytest-flake8-1.0.7.patch branch April 8, 2022 11:14
@paper42 paper42 restored the 0001-New-package-python3-pytest-flake8-1.0.7.patch branch April 8, 2022 11:14
@paper42 paper42 deleted the 0001-New-package-python3-pytest-flake8-1.0.7.patch branch April 8, 2022 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants