New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btrfs-progs: update to 5.11 #29547
btrfs-progs: update to 5.11 #29547
Conversation
f22dcd5
to
0813f08
Compare
Have run on my machine without problems for 2 days. |
0813f08
to
1736481
Compare
It might have cross issues, but maybe not. It was done in 0b78c86, idk why.
Either try removing the failing ones, or we can look into adding more tools to |
That will be tough. I have only tried with 2/3 of the tests but already had to disable 20 of them. Doing more will clutter the template file.
I will try cross building with Python binding enabled to see what goes wrong. |
1 more question: |
Does it end up dynamically linked against the library from |
Yes it links in runtime. I will go with the build option |
1838127
to
244516d
Compare
You're right. Cross build fails with Python. |
I'd rather wait for a request, unless you want to use them yourself? |
ea253b8
to
f2ccd07
Compare
I don't intend to use it so will disable Python bindings for now. |
f2ccd07
to
32a248a
Compare
32a248a
to
d0c7b93
Compare
@folliehiyuki I think that here it is the case to completely disable tests with |
@ologantr Thanks for testing it. I also have run it locally since starting the PR with no issue.
The commit message change is enough. |
@folliehiyuki I have just spoken with @ericonr and he said that he probably won't have time to add functionalities to |
d0c7b93
to
d849652
Compare
Alright I disabled the tests and left a comment. |
- Add build options for btrfs-convert. - Temporarily disable all tests, since most of them fail without `mount` or `fallocate` commands.
d849652
to
1e3eeb5
Compare
General
Have the results of the proposed changes been tested?
Taken over and closes #28153
Why do we disable Python bindings for
libbtrfsutil
?I gave up half way through cherry-picking tests to disable :) Most of them fail without
mount
command from util-linux.Welcome other for battle test.