Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs-progs: update to 5.11 #29547

Merged
merged 1 commit into from Jun 2, 2021
Merged

Conversation

folliehiyuki
Copy link
Contributor

@folliehiyuki folliehiyuki commented Mar 17, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Taken over and closes #28153
Why do we disable Python bindings for libbtrfsutil?
I gave up half way through cherry-picking tests to disable :) Most of them fail without mount command from util-linux.
Welcome other for battle test.

@folliehiyuki folliehiyuki changed the title [WIP] btrfs-progs: update to 5.11 btrfs-progs: update to 5.11 Mar 19, 2021
@folliehiyuki
Copy link
Contributor Author

folliehiyuki commented Mar 19, 2021

Have run on my machine without problems for 2 days.
Basic commands work as expected, so does snapshotting.
I still don't know what to do with the failed tests.
And should I re-enable the Python bindings?

@ericonr
Copy link
Member

ericonr commented Mar 19, 2021

And should I re-enable the Python bindings?

It might have cross issues, but maybe not. It was done in 0b78c86, idk why.

I still don't know what to do with the failed tests.

Either try removing the failing ones, or we can look into adding more tools to chroot-util-linux, maybe...

@folliehiyuki
Copy link
Contributor Author

Either try removing the failing ones

That will be tough. I have only tried with 2/3 of the tests but already had to disable 20 of them. Doing more will clutter the template file.

It might have cross issues, but maybe not. It was done in 0b78c86, idk why.

I will try cross building with Python binding enabled to see what goes wrong.

@folliehiyuki
Copy link
Contributor Author

1 more question: btrfs can convert reiserfs disk into btrfs. Seeing that the file system is old, etc. it is currently disabled in build.
Is it worth enabling? It will bring reiserfsprogs into the dependencies, but maybe someone might need it

@ericonr
Copy link
Member

ericonr commented Mar 19, 2021

Does it end up dynamically linked against the library from reiserfsprogs? If so, I'd be mostly against adding it, or at most make it a build option.

@folliehiyuki
Copy link
Contributor Author

Yes it links in runtime. I will go with the build option

@folliehiyuki folliehiyuki force-pushed the btrfs-update branch 3 times, most recently from 1838127 to 244516d Compare March 19, 2021 23:30
@folliehiyuki
Copy link
Contributor Author

You're right. Cross build fails with Python.
Should I use build option for it? At least x86_64 people will know that it exists and they might want to use it.

@ericonr
Copy link
Member

ericonr commented Mar 19, 2021

Should I use build option for it? At least x86_64 people will know that it exists and they might want to use it.

I'd rather wait for a request, unless you want to use them yourself?

@folliehiyuki folliehiyuki force-pushed the btrfs-update branch 2 times, most recently from ea253b8 to f2ccd07 Compare March 20, 2021 00:10
@folliehiyuki
Copy link
Contributor Author

folliehiyuki commented Mar 20, 2021

I don't intend to use it so will disable Python bindings for now.
There is probably nothing I can do with the tests right now, so ready to be merged.

@ologantr
Copy link
Contributor

ologantr commented Jun 1, 2021

@folliehiyuki I think that here it is the case to completely disable tests with make_check=no as the majority of them require mount(8) which is not shipped with chroot-util-linux.
Other than that, I have tested this and it works like a charm.
Maybe this PR should be renamed to btrfs-progs: update to 5.12.1

@folliehiyuki
Copy link
Contributor Author

@ologantr Thanks for testing it. I also have run it locally since starting the PR with no issue.
I think @ericonr said something about adding functionalities to chroot-util-linux (that way we probably can pass the tests).

Maybe this PR should be renamed to btrfs-progs: update to 5.12.1

The commit message change is enough.

@ologantr
Copy link
Contributor

ologantr commented Jun 1, 2021

@folliehiyuki I have just spoken with @ericonr and he said that he probably won't have time to add functionalities to chroot-util-linux for a long while. For the time being it's best to disable tests altogether.

@folliehiyuki
Copy link
Contributor Author

Alright I disabled the tests and left a comment.

- Add build options for btrfs-convert.
- Temporarily disable all tests, since most of them fail without
`mount` or `fallocate` commands.
@ericonr ericonr merged commit 6592edd into void-linux:master Jun 2, 2021
@folliehiyuki folliehiyuki deleted the btrfs-update branch June 2, 2021 04:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants