Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapper: update to 0.9.0 #30391

Merged
merged 1 commit into from Apr 25, 2021
Merged

Conversation

folliehiyuki
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

We probably should wait for #29547 to be merged first.

@folliehiyuki folliehiyuki marked this pull request as ready for review April 20, 2021 15:56
@folliehiyuki folliehiyuki changed the title [WIP] snapper: update to 0.9.0 snapper: update to 0.9.0 Apr 20, 2021
@folliehiyuki
Copy link
Contributor Author

Technically not a WIP, I put it there with intention to wait for btrfs-progs :)
Some of the locale tests ran on musl while failing on glibc, so I just disable them all.

@Piraty Piraty merged commit 38f7689 into void-linux:master Apr 25, 2021
@Piraty
Copy link
Member

Piraty commented Apr 25, 2021

thanks for adopting it!

@folliehiyuki folliehiyuki deleted the snapper-update branch April 25, 2021 21:13
@folliehiyuki
Copy link
Contributor Author

@Piraty does this work with our current btrfs-progs 5.9? I run 5.11.1 already so I couldn't test

@Piraty
Copy link
Member

Piraty commented Apr 26, 2021

I did not test this as I assumed you (as new maintainer) would have noted otherwise.
(you can downgrade though)

@folliehiyuki
Copy link
Contributor Author

Yes sorry about that.
I did downgrade for a few hours to test the commands and the cron jobs. But I moved back to 5.11.1 after that. I already noted above that we probably should wait, as I don't trust myself that much with those few hours. Though I can confirm the cron jobs and the commands works as expected.

@Piraty
Copy link
Member

Piraty commented Apr 26, 2021

oh I'm sorry, my bad really! i didn't spot the cross-reference to the btrfs-progs PR in the top post.
let's keep as is now and revert only if necessary

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants