[WIP] cgal: update to 5.2.1

[karl-nilsson]

• I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

• I built this PR locally for my native architecture, x64-glibc

TODO

• cgal: missing cgal_create_cmake_script
• cgal: tests not working testsuite not included in releases
• bump cgal rdeps
  • openscad
  • PrusaSlicer
  • dust3d (rebuild fails)

[ericonr]

I believe this PR will be repurposed to a cgal update?

[karl-nilsson]

@ericonr yes, and I intend to move the CGAL package over to header-only, as building shared libraries is deprecated, and will likely be removed in a future release.

What's the best way to go about this?

[ericonr]

Overall, I think you should add a warning to the package that it's a header only library, so updates should consider rebuilding dependants, and then revbump dependencies so they shed the shlib requirement :)

[ericonr]

I think these depends should be moved to the main package? Actually, we can simply remove the subpackage and add replaces="cgal-devel>=0" to the template; it will be pulled in automatically, since the previous cgal-devel already depended on it.

[ericonr]

2021-04-16T20:54:12.6865564Z thirdparty/nodemesh/nodemesh/combiner.cpp: In constructor 'nodemesh::Combiner::Mesh::Mesh(const std::vector<QVector3D>&, const std::vector<std::vector<long unsigned int> >&, bool)':
2021-04-16T20:54:12.6867891Z thirdparty/nodemesh/nodemesh/combiner.cpp:31:61: error: 'remove_self_intersections' is not a member of 'CGAL::Polygon_mesh_processing'; did you mean 'self_intersections'?
2021-04-16T20:54:12.6869289Z    31 |                         if (!CGAL::Polygon_mesh_processing::remove_self_intersections(*cgalMesh)) {
2021-04-16T20:54:12.6870025Z       |                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~

CGAL has apparently broken compatibility with (our version of) dust3d

Maybe try to look at this file's history in their repo to see if you spot any possible patches to import?

[karl-nilsson]

2021-04-16T20:54:12.6865564Z thirdparty/nodemesh/nodemesh/combiner.cpp: In constructor 'nodemesh::Combiner::Mesh::Mesh(const std::vector<QVector3D>&, const std::vector<std::vector<long unsigned int> >&, bool)':
2021-04-16T20:54:12.6867891Z thirdparty/nodemesh/nodemesh/combiner.cpp:31:61: error: 'remove_self_intersections' is not a member of 'CGAL::Polygon_mesh_processing'; did you mean 'self_intersections'?
2021-04-16T20:54:12.6869289Z    31 |                         if (!CGAL::Polygon_mesh_processing::remove_self_intersections(*cgalMesh)) {
2021-04-16T20:54:12.6870025Z       |                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~

CGAL has apparently broken compatibility with (our version of) dust3d

Maybe try to look at this file's history in their repo to see if you spot any possible patches to import?

Will do

[karl-nilsson]

This PR is too stale, I'm closing it.