openscad: update to 2021.01 #30011
Merged
openscad: update to 2021.01 #30011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, so the difference in that PR is that it's also updating cgal, which has other dependants and looks to be somewhat complicated. It looks like openscad can be updated and still use old cgal, so I think we should do that; then the other PR can just revbump it along with other packages. @karl-nilsson are you ok with that? |
|
Yes, sorry for letting my PR go stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the results of the proposed changes been tested?
I saw that #29552 is already open, but the CI checks were failing on that PR for some reason (and there were some TODOs related to broken CGAL tests). I'm not sure what's going on there, but this works for me & seems to be a smaller change, so I'm making this PR in the hopes that it might be easier to merge in.