Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer1: update to 1.18.4 #29558

Closed
wants to merge 10 commits into from
Closed

Conversation

astralchan
Copy link
Contributor

@astralchan astralchan commented Mar 18, 2021

Update gstreamer1 and plugins to 1.18.4

@ericonr
Copy link
Member

ericonr commented Mar 18, 2021

This should be one commit per affected package.

@astralchan
Copy link
Contributor Author

This should be one commit per affected package.

Okay, git reset HEAD~ and added each package to their seperate tracking index - each package affected has their own commit. While we're here - I was wondering if it would be possible to change gstreamer1 to just gstreamer? Upstream is just gstreamer, idk y one wants the 1 at the end - only resulting in having to get rid of it - e.g. ${pkgname/1/}

@travankor
Copy link
Contributor

(this does not fix this from my testing)

Can you remove the fixes to not autoclose the issue?

@astralchan
Copy link
Contributor Author

(this does not fix this from my testing)

Can you remove the fixes to not autoclose the issue?

oops - ya, removed

@ericonr
Copy link
Member

ericonr commented Mar 19, 2021

This is missing gstreamer-vaapi, gst1-editing-services and gst1-python3, I believe.

@astralchan
Copy link
Contributor Author

This is missing gstreamer-vaapi, gst1-editing-services and gst1-python3, I believe.

Okay, I added those three.

@astralchan
Copy link
Contributor Author

I'm still wondering if it's possible (either on this PR or future one) to change gstreamer1 stuff to just gstreamer stuff - this would allow for a big cleanup in shlibs in common, as well, I believe. That way, you don't need a bunch of <gstreamer-stuff>.so <gstreamer1-stuff> lines.

@ericonr ericonr closed this in 24effda Apr 7, 2021
@ericonr
Copy link
Member

ericonr commented Apr 7, 2021

change gstreamer1 stuff to just gstreamer stuff - this would allow for a big cleanup in shlibs in common, as well, I believe. That way, you don't need a bunch of .so lines.

You still need the item in the list; it isn't calculated automatically by package name.

@astralchan
Copy link
Contributor Author

Ah ok. Can the PR still be open for the update? Why did it close?

@ericonr
Copy link
Member

ericonr commented Apr 7, 2021

I had to merge locally, GH UI is bugged. You can find the commits in master.

adbrown101 pushed a commit to adbrown101/void-packages that referenced this pull request Apr 12, 2021
hazayan pushed a commit to hazayan/void-packages that referenced this pull request Apr 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants