Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] screen: don't enable multiuser mode by default. #30241

Merged
merged 1 commit into from Jul 22, 2021

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Apr 14, 2021

This requires that the screen binary be suid.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

This requires that the screen binary be suid.
@ericonr ericonr merged commit ad66ec8 into void-linux:master Jul 22, 2021
@ericonr ericonr deleted the screen branch July 22, 2021 19:22
@tornaria
Copy link
Contributor

This actually prevents screen from running at all:

$ screen
Cannot make directory '/run/screens': Permission denied

Ideas:

  • Maybe some init script should mkdir -m 1777 /run/screens at startup?
  • Maybe removing --with-socket-dir=/run/screens would use an alternative default which works for all users?

@ericonr
Copy link
Member Author

ericonr commented Jul 23, 2021

Damnit, I only tested when the directory already existed :/

@ericonr
Copy link
Member Author

ericonr commented Jul 23, 2021

Maybe removing --with-socket-dir=/run/screens would use an alternative default which works for all users?

Would be nice but breaks existing sessions unless the person sets SCREENDIR. I think that's worse...

Maybe some init script should mkdir -m 1777 /run/screens at startup?

Good enough, IMO.

@tornaria
Copy link
Contributor

I also like the mkdir choice better, because it allows one to easily reenable multiuser screen by just making the binary setuid.

Note that since /run is cleaned at reboots (or a tmpfs) the directory has to be created at every boot, not at install time.

@ericonr
Copy link
Member Author

ericonr commented Jul 23, 2021

I am opening a PR in a bit. Initially I went with removing socket-dir, but realized the potential for breakage.

@ericonr
Copy link
Member Author

ericonr commented Jul 23, 2021

@tornaria #32159

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants