screen: fix launch. #32159
Merged
screen: fix launch. #32159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
When screen isn't suid, it can't create the directory under /run/screens for sessions to sit in. We went with the approach of creating the directory at boot time instead of removing --with-socket-dir so screen would default to using ~/.screen, because it would require users with currently running screen sessions to launch the screen client with SCREENDIR set correctly, and an INSTALL.msg to warn users.
|
Looks good to me. Maybe it should also create |
|
You're not wrong, but I'm dreading having to fix the package again. Would you be interested in making a PR? |
|
See #32201 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When screen isn't suid, it can't create the directory under /run/screens
for sessions to sit in. We went with this approach instead of removing
--with-socket-dir so screen would default to using ~/.screen, becaise it
would require users with currently running screen sessions to launch the
screen client with SCREENDIR set correctly.
Since that approach would be more complicated for users and require
leaving an INSTALL.msg in the package for some time, we went with a
simpler one of always creating the directory at build time.
General
Have the results of the proposed changes been tested?