Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: telegram-tg-0.17.0 #30458

Merged
merged 2 commits into from
May 17, 2021
Merged

New package: telegram-tg-0.17.0 #30458

merged 2 commits into from
May 17, 2021

Conversation

mxkrsv
Copy link
Contributor

@mxkrsv mxkrsv commented Apr 23, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr ericonr added the new-package This PR adds a new package label Apr 25, 2021
@Piraty
Copy link
Member

Piraty commented Apr 25, 2021

please take a look at why do_check() fails for some archs

@folliehiyuki
Copy link
Contributor

There is no test to run so we should add do_check=no there.
And don't add fzf, urlview, ffmpeg to depends. They are optional.

@mxkrsv mxkrsv changed the title New package: telegram-tg-0.12.0 New package: telegram-tg-0.15.0 Apr 26, 2021
@folliehiyuki
Copy link
Contributor

folliehiyuki commented Apr 26, 2021

You can pull the distfile for python3-telegram from Github, so that we don't need to vendor the LICENSE file. And it builds fine without explicitly disable check, so we don't need make_check=no there.

0.16.0 for tg came out. You can add a comment that there is no test to run before the make_check=no line.

srcpkgs/python3-telegram/template Outdated Show resolved Hide resolved
srcpkgs/python3-telegram/template Outdated Show resolved Hide resolved
@mxkrsv mxkrsv changed the title New package: telegram-tg-0.15.0 New package: telegram-tg-0.16.0 Apr 27, 2021
@mxkrsv mxkrsv changed the title New package: telegram-tg-0.16.0 New package: telegram-tg-0.17.0 Apr 27, 2021
@mxkrsv mxkrsv requested a review from Piraty April 28, 2021 14:21
@mxkrsv mxkrsv requested a review from Piraty May 2, 2021 08:11
@mxkrsv mxkrsv requested a review from Piraty May 10, 2021 15:09
@Piraty
Copy link
Member

Piraty commented May 10, 2021

I will merge this, but i ask you to bring library detection to upstream's attention

@mxkrsv
Copy link
Contributor Author

mxkrsv commented May 11, 2021

It's already a known issue and there is a better fix, I should have looked at issues first.
alexander-akhmetov/python-telegram#119
Looks like upstream won't change library detection behavior in the foreseeable future

@Piraty Piraty merged commit 5854a23 into void-linux:master May 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants